Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): CLI command write-translations should extract translations from @docu… #7996

Merged
merged 1 commit into from Aug 24, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 24, 2022

Motivation

Fix #7983

Test Plan

none 😅 we need more tests on these CLI commands, only swizzle have good tests

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@slorber slorber added pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus labels Aug 24, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 24, 2022
@netlify
Copy link

netlify bot commented Aug 24, 2022

[V2]

Name Link
🔨 Latest commit e75b39b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6305fe08d05d290008ad096e
😎 Deploy Preview https://deploy-preview-7996--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 91 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 814 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.5 kB
website/build/assets/css/styles.********.css 111 kB
website/build/assets/js/main.********.js 610 kB
website/build/index.html 40.8 kB

compressed-size-action

@slorber slorber merged commit cee1b4b into main Aug 24, 2022
@slorber slorber deleted the slorber/fix-writeTranslations-theme-common branch August 24, 2022 10:45
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WARNING] Unused default message codes found.
2 participants