Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): remove hard-coded tag border-radius #8062

Merged
merged 1 commit into from Sep 8, 2022

Conversation

homotechsual
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

.tagRegular has a fixed 0.5REM border radius - it's the only place I've found that doesn't inherit from --ifm-global-radius without a good reason.

Test Plan

Default behaviour here will be no change unless --ifm-global-radius is customised in which case tag elements will now inherit.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

.tagRegular should use `--ifm-global-radius` instead of a hardcoded 0.5rem radius.
@netlify
Copy link

netlify bot commented Sep 7, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d5fe4f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6319148fa063fe0009095fcb
😎 Deploy Preview https://deploy-preview-8062--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 64 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 69 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Sep 8, 2022
@Josh-Cena Josh-Cena changed the title Remove hard-coded border-radius refactor(theme): remove hard-coded tag border-radius Sep 8, 2022
@slorber
Copy link
Collaborator

slorber commented Sep 8, 2022

LGTM 👍 this reduces a bit the radius (0.5rem -> 0.4rem) but actually looks better

@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Sep 8, 2022
@slorber slorber merged commit a0ab2b0 into facebook:main Sep 8, 2022
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants