Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): normalize slashes for url/baseUrl instead of throwing #8066

Merged
merged 1 commit into from Sep 8, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

Motivation

Test Plan

Testing the SiteMetadata is a bit unwieldy atm, so I only wrote validation tests.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added pr: polish This PR adds a very minor behavior improvement that users will enjoy. to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 8, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 8, 2022
@netlify
Copy link

netlify bot commented Sep 8, 2022

[V2]

Name Link
🔨 Latest commit 271e7a2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63196ea786d9490009680e84
😎 Deploy Preview https://deploy-preview-8066--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 82 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 76 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Size Change: 0 B

Total Size: 813 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.1 kB
website/build/assets/css/styles.********.css 111 kB
website/build/assets/js/main.********.js 609 kB
website/build/index.html 40.8 kB

compressed-size-action

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

@slorber slorber merged commit bcae750 into main Sep 8, 2022
@slorber slorber deleted the jc/normalize-url branch September 8, 2022 15:18
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site config url + baseUrl are not normalized and sensitive to leading/trailing slash
3 participants