Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme-classic): store selected tab in query string. #8225

Merged
merged 20 commits into from Dec 9, 2022
Merged

feat(theme-classic): store selected tab in query string. #8225

merged 20 commits into from Dec 9, 2022

Commits on Oct 18, 2022

  1. feat(theme-classic): store selected tab in query string.

    @mturoci
    mturoci committed Oct 18, 2022
    Copy the full SHA
    c621e42 View commit details
    Browse the repository at this point in the history

  2. test: fix failing tests

    @mturoci
    mturoci committed Oct 18, 2022
    Copy the full SHA
    634c0f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. chore: Use react router instead of native window location.

    @mturoci
    mturoci committed Oct 24, 2022
    Copy the full SHA
    52fa90b View commit details
    Browse the repository at this point in the history

  2. fix: Make tabs sync work again.

    @mturoci
    mturoci committed Oct 24, 2022
    Copy the full SHA
    04053c5 View commit details
    Browse the repository at this point in the history

  3. test: Temporarily skip tabs tests.

    @mturoci
    mturoci committed Oct 24, 2022
    Copy the full SHA
    216119d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. fix: Make queryString param optional.

    @mturoci
    mturoci committed Oct 25, 2022
    Copy the full SHA
    cabac96 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2022

  1. test: Remove tab unit test skip.

    @mturoci
    mturoci committed Oct 30, 2022
    Copy the full SHA
    80e978d View commit details
    Browse the repository at this point in the history

  2. feat: Querystring user props valdiation.

    @mturoci
    mturoci committed Oct 30, 2022
    Copy the full SHA
    6e1fb03 View commit details
    Browse the repository at this point in the history

  3. chore: Remove unnecessary env var.

    @mturoci
    mturoci committed Oct 30, 2022
    Copy the full SHA
    7eb1334 View commit details
    Browse the repository at this point in the history

  4. chore: Refactor.

    @mturoci
    mturoci committed Oct 30, 2022
    Copy the full SHA
    66a3939 View commit details
    Browse the repository at this point in the history

  5. docs: Document the tab querystring behavior.

    @mturoci
    mturoci committed Oct 30, 2022
    Copy the full SHA
    4213dc2 View commit details
    Browse the repository at this point in the history

  6. chore: Remove unnecessary and outdated comments.

    @mturoci
    mturoci committed Oct 30, 2022
    Copy the full SHA
    60813d8 View commit details
    Browse the repository at this point in the history

  7. fix: Remove forgotten code for default value.

    @mturoci
    mturoci committed Oct 30, 2022
    Copy the full SHA
    5e38a1f View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. better querystring implementation refactor

    @slorber
    slorber committed Dec 9, 2022
    Copy the full SHA
    f8eb751 View commit details
    Browse the repository at this point in the history

  2. better tab querystring doc

    @slorber
    slorber committed Dec 9, 2022
    Copy the full SHA
    13aec5d View commit details
    Browse the repository at this point in the history

  3. ensure queryString wins over localStorage

    @slorber
    slorber committed Dec 9, 2022
    Copy the full SHA
    3d2a36f View commit details
    Browse the repository at this point in the history

  4. doc

    @slorber
    slorber committed Dec 9, 2022
    Copy the full SHA
    0d48df6 View commit details
    Browse the repository at this point in the history

  5. // highlight-next-line

    @slorber
    slorber committed Dec 9, 2022
    Copy the full SHA
    5264f83 View commit details
    Browse the repository at this point in the history

  6. fix scrollAfterNavigation logic to not mess-up with query-string chan… 

    …ges from <Tabs queryString>
    @slorber
    slorber committed Dec 9, 2022
    Copy the full SHA
    1bd6561 View commit details
    Browse the repository at this point in the history

  7. fix tab selected value restoration logic

    @slorber
    slorber committed Dec 9, 2022
    Copy the full SHA
    c2eca08 View commit details
    Browse the repository at this point in the history