Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): add plugin to exported configs #8281

Merged
merged 2 commits into from
Dec 7, 2022
Merged

feat(eslint-plugin): add plugin to exported configs #8281

merged 2 commits into from
Dec 7, 2022
+12 −12

Conversation

lachieh
Copy link
Contributor

@lachieh lachieh commented Nov 2, 2022 •
edited by Josh-Cena
Loading

Pre-flight checklist

Motivation

See #8280 for details

Test Plan

Change to config might require a minor version change.

Test links

Related issues/PRs

Closes #8280

Sorry, something went wrong.

@lachieh lachieh requested a review from slorber as a code owner November 2, 2022 15:12
@netlify
Copy link

netlify bot commented Nov 2, 2022 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit abefed2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/638f6c1df0a0d30008b70a1f
😎 Deploy Preview https://deploy-preview-8281--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 93 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber
Copy link
Collaborator

slorber commented Nov 2, 2022

@Josh-Cena let me know if you have any opinion on this otherwise I'll review it later.

That seems like a reasonable change to do 👍

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 2, 2022
@Josh-Cena Josh-Cena changed the title Add plugin to exported configs and update docs feat(eslint-plugin): add plugin to exported configs Dec 3, 2022
@Josh-Cena Josh-Cena added pr: polish This PR adds a very minor behavior improvement that users will enjoy. to backport This PR is planned to be backported to a stable version of Docusaurus labels Dec 3, 2022
@Josh-Cena Josh-Cena self-requested a review as a code owner December 3, 2022 00:35
Josh-Cena
Josh-Cena approved these changes Dec 3, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks!

lachieh and others added 2 commits December 6, 2022 11:21
@lachieh
add eslint plugin to config and update docs
9639c45
@Josh-Cena @lachieh
Update README.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
abefed2
@lachieh lachieh requested a review from lex111 as a code owner December 6, 2022 16:21
@slorber
Copy link
Collaborator

slorber commented Dec 7, 2022

Thanks 👍

@slorber slorber merged commit 85d0b56 into facebook:main Dec 7, 2022
@lachieh lachieh deleted the feature/add-eslint-plugin-to-config branch December 8, 2022 17:44
slorber pushed a commit that referenced this pull request Jan 26, 2023
@lachieh @slorber
feat(eslint-plugin): add plugin to exported configs (#8281)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
3eb866a 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
closes undefined
Closes #8280
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 27, 2023
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena

@slorber slorber

@lex111 lex111

Assignees
No one assigned
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@docusaurus/eslint-plugin] Add plugin setting to recommended eslint config
4 participants
@lachieh @slorber @Josh-Cena @facebook-github-bot