fix(content-blog): blog Atom feed id + RSS feed guid should be fully qualified urls #8381
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyreilly
changed the title
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
johnnyreilly
changed the title
slorber
changed the title
slorber
changed the title
|
LGTM thanks 👍 RSS feed validation: https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fdocusaurus.io%2Fblog%2Frss.xml Other useful refs: |
slorber
added
the
to backport
slorber
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Closes #8380
The Atom feed fails validation:
The error:
The same issue exists for RSS.
I've been able to patch it on my own blog using this: https://github.com/johnnyreilly/blog.johnnyreilly.com/pull/357/files#diff-a6704bb15d419cd24c7a855d8188b83b36aa4a6011c40b63c8dc9f5bb60fc2ed
It would be better to fix at source - this PR does that by setting
idto be the URL as required.Test Plan
See updated snapshots.
See successful validation on deploy preview:
Test links
Deploy preview: https://deploy-preview-8381--docusaurus-2.netlify.app/blog/atom.xml
It's worth noting that there's an outstanding issue with RSS feeds as RSS doesn't support multiple authors. However this is a limitation of the RSS standard. Atom is incidentally fine.
Related issues/PRs
#8380