feat(core): deploy CLI - add support for git url "insteadOf": use 'remote get-url' to determine source repo url #8397
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
changed the title
slorber
changed the title
slorber
added
pr: new feature
|
Makes sense and looks safe to merge thanks Can you explain the motivation to use insteadOf with Docusaurus? I'm not very familiar with this git feature so curious to know more |
slorber
changed the title
slorber
added
the
to backport
slorber
pushed a commit
that referenced
this pull request
Jan 26, 2023
…mote get-url' to determine source repo url (#8397)
slorber
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor simplification/optimization in the way the repo source url is determined during deployment.
Instead of directly extracting the raw value from config, use the more idiomatic, built-in command:
It has the added benefit that a potential
insteadOfconfiguration is also taken into account.See git remote man page for additional details.