Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: growth of content container to take all the available space #8409

Closed
wants to merge 1 commit into from
Closed

fix: growth of content container to take all the available space #8409

wants to merge 1 commit into from

Conversation

pulkit-30
Copy link

@pulkit-30 pulkit-30 commented Dec 4, 2022

fixes: #8369

Issue fix: To prevent content container growth, to take all the available space.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Before:

After

Screenshot 2022-12-04 at 4 53 17 PM

ref: changes:

@facebook-github-bot
Copy link
Contributor

Hi @pulkit-30!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Dec 4, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f3e32b6
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/638c84982422b000087820bb
😎 Deploy Preview https://deploy-preview-8409--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 92 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 6, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 8, 2022
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying

Unfortunately it doesn't work as expected. We want the footer to reach the end of our page here.

CleanShot 2022-12-08 at 16 49 04

@@ -11,7 +11,7 @@ body {
}

.mainWrapper {
flex: 1 0 auto;
flex: 1 0 none;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, do you have and ref doc mentioning this "none" value?

According to what I find it's only valid when using flex: 'none' but not as a 3rd position?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I miss that thing...
trying again

@slorber slorber marked this pull request as draft December 8, 2022 15:50
@pulkit-30
Copy link
Author

Thanks for trying
Unfortunately it doesn't work as expected. We want the footer to reach the end of our page here.

Let me try again!

@slorber
Copy link
Collaborator

slorber commented Dec 22, 2022

This is a better fix: #8463

@slorber slorber closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs layout issue: content container does not grow to take all the available space
3 participants