Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(algolia): make search footer respect searchPagePath #8539

Merged
merged 1 commit into from Jan 19, 2023

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 10, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 10, 2023
@netlify
Copy link

netlify bot commented Jan 10, 2023

[V2]

Name Link
🔨 Latest commit 0ee6e12
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63be3e0555cafd0009758c8f
😎 Deploy Preview https://deploy-preview-8539--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jan 10, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 93 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Size Change: +45 B (0%)

Total Size: 890 kB

Filename Size Change
website/build/assets/js/main.********.js 666 kB +45 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 71 kB
website/build/assets/css/styles.********.css 112 kB
website/build/index.html 40.9 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jan 19, 2023

LGTM thanks 👍

@slorber slorber merged commit 19c1e27 into main Jan 19, 2023
@slorber slorber deleted the jc/search-footer branch January 19, 2023 13:14
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

algolia.searchPagePath is not respected in resultsFooterComponent
3 participants