feat(theme-translations): default translations for Slovenian (sl-SI)

[MatijaSi]

Pre-flight checklist

• I have read the Contributing Guidelines on pull requests.

[facebook-github-bot]

Hi @MatijaSi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[netlify]

✅ [V2]

Name	Link
🔨 Latest commit	5c4ea10
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/63c9714133ffc50008e4128c
😎 Deploy Preview	https://deploy-preview-8541--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[github-actions]

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🔴 18	🟢 97	🟢 92	🟢 100	🟢 90	Report
/docs/installation	🟠 62	🟢 100	🟢 92	🟢 100	🟢 90	Report

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[Josh-Cena]

Thank you for the contribution. Could you take a look at https://github.com/facebook/docusaurus/tree/main/packages/docusaurus-theme-translations for instructions on how to create translations? Your generated JSON should look like https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-theme-translations/locales/ar/plugin-ideal-image.json, without the description fields.

[slorber]

Thanks, almost looks good.

I removed the useless __DESCRIPTION fields from your PR.

The plural forms are wrong, they should only contain 4 values instead of 5.

function getLocalePluralForms(locale) {
  const AllPluralForms = ['zero','one','two','few','many','other']
  const pluralCategories = new Intl.PluralRules(locale).resolvedOptions().pluralCategories;
  pluralCategories.sort((c1,c2) => AllPluralForms.indexOf(c1) > AllPluralForms.indexOf(c2) ? 1 : -1);
  return pluralCategories;
}

const myLocale = "sl"; // Change this variable!
console.log("Plural forms for this locale are =>>> ",getLocalePluralForms(myLocale)); 

Plural forms for this locale are =>>>  (4) ['one', 'two', 'few', 'other']

Unfortunately I don't speak sl and can't fix the existing forms 😅

---

You can get more info about plural forms here:
#3526

Also refer to this table:

https://www.unicode.org/cldr/cldr-aux/charts/34/supplemental/language_plural_rules.html

---

Can't be sure but my intuition is that you should merge the 3rd and 4th plural forms because they all use the same suffix for 3 and 4 quantities: "{count} prispevki" / "{count} minute branja" / "{count} dokumenti imajo oznako" / "{count} dokumenti najdeni"

  "theme.blog.post.plurals": "En prispevek|Dva prispevka|{count} prispevki|{count} prispevkov",

Please confirm and/or update your pr

[slorber]

we should only have 4 plural forms

[slorber]

same

[slorber]

same

[slorber]

same

[slorber]

Going to move on and apply my suggestion. Feel free to open another pr if I was wrong

[MatijaSi]

@slorber

Slovenian has 4 plural forms, however until when we reach number 5 verb "imeti" refers to documents, while after (ex. "5 dokumentov ima") "imeti" verb doesn't refer anymore to "dokumentov", but to "5" (so it goes back to singular form). So we need to cover 5 distinct cases.

[slorber]

@MatijaSi our pluralization system is based in the Intl apis and those API return only 4 cases, so even if you provide a 5th label, it will never be used by Docusaurus.

Docusaurus selects the string part to use according to the plural rule returned.

I don't really understand what you say above 😅

The string parts are not related to the number of documents, but the position of the plural form in that array: ['one', 'two', 'few', 'other']

If n >= 5 in sl is the "other" plural form, it should be the 4th string part of the translation string and not the 5th part. Hope it's clearer?

[slorber]

This "other" plural form for numbers >= 5 should appear in 4th position in our translation string because it's the 4th plural form in that table.

Does it make sense?

[MatijaSi]

Thank you for explanation, it makes sense.

If only 4 plurals are available I need to change translation, give me 20 minutes.

Point is that, for example "One doc tagged|{count} docs tagged" can be translated two ways. One is "Dokument ima oznako" (document has tag), which is more idiomatic, while other is "Dokument z oznako" (document with tag).

Problem is that first requires 5 variations based on number of documents (since when we reach number 5 subject of verb has to change, which changes verb). Second only requires 4 variations (singular, double, few, many) so I will change to it.

Thanks!

[MatijaSi]

Eh sorry, I misremembered. 5c4ea10 is okay. I thought "Štirje dokumentje" was used for fourth case, not "štirje dokumenti". Both are correct, with second having advantage that only four variations are present.

[slorber]

great, thanks ;)