feat(theme-translations): default translations for Slovenian (sl-SI) #8541

MatijaSi · 2023-01-11T06:46:33Z

Pre-flight checklist

I have read the Contributing Guidelines on pull requests.

facebook-github-bot · 2023-01-11T06:46:38Z

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

netlify · 2023-01-11T06:50:58Z

✅ [V2]

Name	Link
🔨 Latest commit	`5c4ea10`
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/63c9714133ffc50008e4128c
😎 Deploy Preview	https://deploy-preview-8541--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2023-01-11T06:51:40Z

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🔴 18	🟢 97	🟢 92	🟢 100	🟢 90	Report
/docs/installation	🟠 62	🟢 100	🟢 92	🟢 100	🟢 90	Report

facebook-github-bot · 2023-01-11T07:57:42Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Josh-Cena

Thank you for the contribution. Could you take a look at https://github.com/facebook/docusaurus/tree/main/packages/docusaurus-theme-translations for instructions on how to create translations? Your generated JSON should look like https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-theme-translations/locales/ar/plugin-ideal-image.json, without the description fields.

slorber

Thanks, almost looks good.

I removed the useless __DESCRIPTION fields from your PR.

The plural forms are wrong, they should only contain 4 values instead of 5.

function getLocalePluralForms(locale) {
  const AllPluralForms = ['zero','one','two','few','many','other']
  const pluralCategories = new Intl.PluralRules(locale).resolvedOptions().pluralCategories;
  pluralCategories.sort((c1,c2) => AllPluralForms.indexOf(c1) > AllPluralForms.indexOf(c2) ? 1 : -1);
  return pluralCategories;
}

const myLocale = "sl"; // Change this variable!
console.log("Plural forms for this locale are =>>> ",getLocalePluralForms(myLocale));

Plural forms for this locale are =>>>  (4) ['one', 'two', 'few', 'other']

Unfortunately I don't speak sl and can't fix the existing forms 😅

You can get more info about plural forms here:
#3526

Also refer to this table:

https://www.unicode.org/cldr/cldr-aux/charts/34/supplemental/language_plural_rules.html

Can't be sure but my intuition is that you should merge the 3rd and 4th plural forms because they all use the same suffix for 3 and 4 quantities: "{count} prispevki" / "{count} minute branja" / "{count} dokumenti imajo oznako" / "{count} dokumenti najdeni"

  "theme.blog.post.plurals": "En prispevek|Dva prispevka|{count} prispevki|{count} prispevkov",

Please confirm and/or update your pr

slorber · 2023-01-19T14:17:31Z

packages/docusaurus-theme-translations/locales/sl/theme-common.json

+  "theme.blog.post.paginator.navAriaLabel": "Navigacija prispevka na blogu",
+  "theme.blog.post.paginator.newerPost": "Novejši prispevek",
+  "theme.blog.post.paginator.olderPost": "Starejši prispevek",
+  "theme.blog.post.plurals": "En prispevek|Dva prispevka|Trije prispevki|Štirje prispevki|{count} prispevkov",


we should only have 4 plural forms

slorber · 2023-01-19T14:17:40Z

packages/docusaurus-theme-translations/locales/sl/theme-common.json

+  "theme.blog.post.plurals": "En prispevek|Dva prispevka|Trije prispevki|Štirje prispevki|{count} prispevkov",
+  "theme.blog.post.readMore": "Preberite več",
+  "theme.blog.post.readMoreLabel": "Preberite več o {title}",
+  "theme.blog.post.readingTime.plurals": "Minuta branja|Minuti branja|Tri minute branja|Štiri minute branja|{readingTime} minut branja",


slorber · 2023-01-19T14:17:49Z

packages/docusaurus-theme-translations/locales/sl/theme-common.json

+  "theme.docs.sidebar.navAriaLabel": "Stranska vrstica dokumentacije",
+  "theme.docs.sidebar.toggleSidebarButtonAriaLabel": "Preklopi navigacijsko vrstico",
+  "theme.docs.tagDocListPageTitle": "{nDocsTagged} ima oznako \"{tagName}\"",
+  "theme.docs.tagDocListPageTitle.nDocsTagged": "En dokument ima oznako|Dva dokumenta imata oznako|Trije dokumenti imajo oznako|Štirje dokumenti imajo oznako|{count} dokumentov ima oznako",


slorber · 2023-01-19T14:17:58Z

packages/docusaurus-theme-translations/locales/sl/theme-search-algolia.json

+  "theme.SearchModal.startScreen.removeRecentSearchButtonTitle": "Umakni iskanje iz zgodovine",
+  "theme.SearchModal.startScreen.saveRecentSearchButtonTitle": "Shrani to iskanje",
+  "theme.SearchPage.algoliaLabel": "Iskanje Algolia",
+  "theme.SearchPage.documentsFound.plurals": "Dokument najden|Dokumenta najdena|Trije dokumenti najdeni|Štirje dokumenti najdeni|{count} dokumentov najdenih",


slorber · 2023-01-19T16:32:53Z

Going to move on and apply my suggestion. Feel free to open another pr if I was wrong

MatijaSi · 2023-01-19T16:38:22Z

@slorber

Slovenian has 4 plural forms, however until when we reach number 5 verb "imeti" refers to documents, while after (ex. "5 dokumentov ima") "imeti" verb doesn't refer anymore to "dokumentov", but to "5" (so it goes back to singular form). So we need to cover 5 distinct cases.

slorber · 2023-01-19T16:50:11Z

@MatijaSi our pluralization system is based in the Intl apis and those API return only 4 cases, so even if you provide a 5th label, it will never be used by Docusaurus.

Docusaurus selects the string part to use according to the plural rule returned.

I don't really understand what you say above 😅

The string parts are not related to the number of documents, but the position of the plural form in that array: ['one', 'two', 'few', 'other']

If n >= 5 in sl is the "other" plural form, it should be the 4th string part of the translation string and not the 5th part. Hope it's clearer?

slorber · 2023-01-19T16:52:24Z

This "other" plural form for numbers >= 5 should appear in 4th position in our translation string because it's the 4th plural form in that table.

Does it make sense?

MatijaSi · 2023-01-19T17:00:27Z

Thank you for explanation, it makes sense.

If only 4 plurals are available I need to change translation, give me 20 minutes.

Point is that, for example "One doc tagged|{count} docs tagged" can be translated two ways. One is "Dokument ima oznako" (document has tag), which is more idiomatic, while other is "Dokument z oznako" (document with tag).

Problem is that first requires 5 variations based on number of documents (since when we reach number 5 subject of verb has to change, which changes verb). Second only requires 4 variations (singular, double, few, many) so I will change to it.

Thanks!

MatijaSi · 2023-01-19T17:03:51Z

Eh sorry, I misremembered. 5c4ea10 is okay. I thought "Štirje dokumentje" was used for fourth case, not "štirje dokumenti". Both are correct, with second having advantage that only four variations are present.

slorber · 2023-01-19T17:13:50Z

great, thanks ;)

…8541) Co-authored-by: Matija Sirk <matija.sirk@kopit.si> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>

Matija Sirk added 10 commits January 10, 2023 13:49

Copied base to sl-SI.

5dbb344

Translated plugin-ideal-image.json to Slovenian.

ad58bf4

Translated plugin-pwa.json to Slovenian.

dd1301d

Translated theme-live-codeblock.json to Slovenian.

cd33ce9

Translated theme-common.json, except *__DESCRIPTION tags.

dcd7321

Translated theme-search-algolia except *__DESCRIPTION tags.

26f44f9

Translated first third of *__DESCRIPTION tags.

a6e0036

Translated remaining *__DESCRIPTION items in theme-common.

b585989

Translated *__DESCRIPTION tags in algolia.

d113c5b

Prenesi is clearer than osveži in pwa refresh context.

401342e

MatijaSi requested review from slorber, lex111 and Josh-Cena as code owners January 11, 2023 06:46

facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 11, 2023

Josh-Cena requested changes Jan 17, 2023

View reviewed changes

Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Jan 17, 2023

Josh-Cena changed the title ~~Default translations for Slovenian (sl-SI)~~ feat(theme-translations): default translations for Slovenian (sl-SI) Jan 17, 2023

slorber added 2 commits January 19, 2023 15:10

remove sl translation __DESCRIPTION attributes

a41816c

rename sl-SI to sl

cb19371

slorber requested changes Jan 19, 2023

View reviewed changes

fix sl plurals

5c4ea10

slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Jan 19, 2023

slorber merged commit c32316e into facebook:main Jan 19, 2023

slorber added a commit that referenced this pull request Jan 26, 2023

feat(theme-translations): default translations for Slovenian (sl-SI) (#…

c6cdf70

…8541) Co-authored-by: Matija Sirk <matija.sirk@kopit.si> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>

slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 27, 2023

slorber mentioned this pull request Oct 19, 2023

chore: v3.0.0-rc.0 release #9418

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(theme-translations): default translations for Slovenian (sl-SI) #8541

feat(theme-translations): default translations for Slovenian (sl-SI) #8541

MatijaSi commented Jan 11, 2023

facebook-github-bot commented Jan 11, 2023

netlify bot commented Jan 11, 2023 •

edited

github-actions bot commented Jan 11, 2023 •

edited

facebook-github-bot commented Jan 11, 2023

Josh-Cena left a comment

slorber left a comment •

edited

slorber Jan 19, 2023

slorber Jan 19, 2023

slorber Jan 19, 2023

slorber Jan 19, 2023

slorber commented Jan 19, 2023

MatijaSi commented Jan 19, 2023 •

edited

slorber commented Jan 19, 2023

slorber commented Jan 19, 2023

MatijaSi commented Jan 19, 2023

MatijaSi commented Jan 19, 2023

slorber commented Jan 19, 2023

feat(theme-translations): default translations for Slovenian (sl-SI) #8541

feat(theme-translations): default translations for Slovenian (sl-SI) #8541

Conversation

MatijaSi commented Jan 11, 2023

Pre-flight checklist

facebook-github-bot commented Jan 11, 2023

Action Required

Process

netlify bot commented Jan 11, 2023 • edited

✅ [V2]

github-actions bot commented Jan 11, 2023 • edited

⚡️ Lighthouse report for the deploy preview of this PR

facebook-github-bot commented Jan 11, 2023

Josh-Cena left a comment

Choose a reason for hiding this comment

slorber left a comment • edited

Choose a reason for hiding this comment

slorber Jan 19, 2023

Choose a reason for hiding this comment

slorber Jan 19, 2023

Choose a reason for hiding this comment

slorber Jan 19, 2023

Choose a reason for hiding this comment

slorber Jan 19, 2023

Choose a reason for hiding this comment

slorber commented Jan 19, 2023

MatijaSi commented Jan 19, 2023 • edited

slorber commented Jan 19, 2023

slorber commented Jan 19, 2023

MatijaSi commented Jan 19, 2023

MatijaSi commented Jan 19, 2023

slorber commented Jan 19, 2023

netlify bot commented Jan 11, 2023 •

edited

github-actions bot commented Jan 11, 2023 •

edited

slorber left a comment •

edited

MatijaSi commented Jan 19, 2023 •

edited