fix(preset-classic): Pass Google Tag Manager configuration to correct plugin #8600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the plugin configuration builder of preset-classic incorrectly sets the configuration for the
googleTagManager
-tag. It tries to pass the Google Tag Manager configuration to the legacy GTag plugin, instead of the new Google Tag Manager plugin.This change routes the configuration to the correct plugin.
Pre-flight checklist
Motivation
The newly added plugin for Google Tag Manager isn't properly integrated with the
classic
-preset, as theclassic
-preset tries to route the newly added config for the GTM plugin to the legacy GTag plugin.Therefore, preventing you from being able to confgure the GTM plugin from the
classic
-preset.Test Plan
Test links
Deploy preview: https://deploy-preview-8600--docusaurus-2.netlify.app/
Related issues/PRs
#8470