Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset-classic): Pass Google Tag Manager configuration to correct plugin #8600

Closed
wants to merge 1 commit into from

Conversation

Addono
Copy link

@Addono Addono commented Jan 30, 2023

The current implementation of the plugin configuration builder of preset-classic incorrectly sets the configuration for the googleTagManager-tag. It tries to pass the Google Tag Manager configuration to the legacy GTag plugin, instead of the new Google Tag Manager plugin.

This change routes the configuration to the correct plugin.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The newly added plugin for Google Tag Manager isn't properly integrated with the classic-preset, as the classic-preset tries to route the newly added config for the GTM plugin to the legacy GTag plugin.

Therefore, preventing you from being able to confgure the GTM plugin from the classic-preset.

Test Plan

Test links

Deploy preview: https://deploy-preview-8600--docusaurus-2.netlify.app/

Related issues/PRs

#8470

… plugin

The current implementation of the plugin configuration builder of preset-classic incorrectly sets the configuration for the `googleTagManager`-tag. It tries to pass the Google Tag Manager configuration to the legacy GTag plugin, instead of the new Google Tag Manager plugin.

This change routes the configuration to the correct plugin.
@facebook-github-bot
Copy link
Contributor

Hi @Addono!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Jan 30, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ea44a8
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63d77f5c3917b70009ef15e1
😎 Deploy Preview https://deploy-preview-8600--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 68 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Addono
Copy link
Author

Addono commented Jan 30, 2023

Any instructions on how to test this change? It seems there's no test coverage for configuring the plugins through the classic-preset.

At least, I cannot find a location in the tests where configuring the legacy GTag plugin is being set. And clearly the new plugin doesn't do this either.

@Addono Addono marked this pull request as ready for review January 30, 2023 08:39
@Addono Addono closed this Jan 30, 2023
@Addono
Copy link
Author

Addono commented Jan 30, 2023

Duplicate of #8597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants