Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-common): localStorage utils dispatch too many storage events leading to infinite loop #8619

Merged
merged 1 commit into from Feb 2, 2023
Merged

fix(theme-common): localStorage utils dispatch too many storage events leading to infinite loop #8619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/docusaurus-theme-common/src/utils/storageUtils.ts
View file
Open in desktop
Expand Up @@ -31,6 +31,13 @@ function dispatchChangeEvent({
newValue: string | null;
storage: Storage;
}) {
// If we set multiple times the same storage value, events should not be fired
// The native events behave this way, so our manual event dispatch should
// rather behave exactly the same. Not doing so might create infinite loops.
// See https://github.com/facebook/docusaurus/issues/8594
if (oldValue === newValue) {
return;
}
const event = document.createEvent('StorageEvent');
event.initStorageEvent(
'storage',
Expand Down