Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add "pr: dependencies" to lerna changelog labels #8622

Merged
merged 1 commit into from Feb 3, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 2, 2023

Our changelog does not include some deps upgrades currently, I think it's useful to have these entries:


🤖 Dependencies

  • docusaurus-plugin-client-redirects, docusaurus-theme-search-algolia, docusaurus

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Feb 2, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 2, 2023
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 In the past we didn't do it because I bumped dependencies too much. This shouldn't happen that often into the future.

@netlify
Copy link

netlify bot commented Feb 2, 2023

[V2]

Name Link
🔨 Latest commit b27eaaf
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63dc0781e5876c0009df63c6
😎 Deploy Preview https://deploy-preview-8622--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 81 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 77 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber merged commit fc64705 into main Feb 3, 2023
@slorber slorber deleted the slorber/add-lerna-dependencies-label branch February 3, 2023 09:16
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Feb 3, 2023
@slorber slorber added to backport This PR is planned to be backported to a stable version of Docusaurus backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants