Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changing shopping card to shopping cart #8898

Merged

Conversation

aqueeb
Copy link
Contributor

@aqueeb aqueeb commented Apr 17, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I saw a spelling mistake and I'm just submitting a fix for it.

Test Plan

Not needed as this is just a docs change.

Test links

Not needed as this is just a docs change.

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 17, 2023
@netlify
Copy link

netlify bot commented Apr 17, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 10d5cf0
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/643ea1073b6859000850c20e
😎 Deploy Preview https://deploy-preview-8898--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 90 🟢 97 🟢 92 🟢 100 🟢 90 Report
/docs/installation 🟠 78 🟢 100 🟢 92 🟢 100 🟢 90 Report

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to update all pages!

@Josh-Cena Josh-Cena merged commit 9c7e29a into facebook:main Apr 19, 2023
2 checks passed
@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Apr 19, 2023
@aqueeb
Copy link
Contributor Author

aqueeb commented Apr 19, 2023

Thanks for taking time to update all pages!

You're most welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants