Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate website config to createConfigAsync #8911

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 20, 2023

Motivation

With MDX 2 (#8288) we will have even more async stuff in our config (math/katex plugins etc)

So I'd prefer to do this needed change right now.
It shouldn't change any behavior.

Test Plan

preview as before

Test links

Deploy preview: https://deploy-preview-8911--docusaurus-2.netlify.app/

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 20, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 20, 2023
@netlify
Copy link

netlify bot commented Apr 20, 2023

[V2]

Name Link
🔨 Latest commit b41d312
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64417c1c576fd700070b6545
😎 Deploy Preview https://deploy-preview-8911--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 60 🟢 97 🟢 92 🟢 100 🟢 90 Report
/docs/installation 🟠 68 🟢 100 🟢 92 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 1.01 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 101 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 752 kB
website/build/index.html 41.3 kB

compressed-size-action

@slorber slorber merged commit 4a4a8be into main Apr 21, 2023
8 checks passed
@slorber slorber deleted the slorber/async-website-config branch April 21, 2023 10:00
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants