Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airstore next: bundle V4: thrift working in OSS build #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

airstore next: bundle V4: thrift working in OSS build #197

wants to merge 1 commit into from

Commits on Apr 27, 2024

  1. airstore next: bundle V4: thrift working in OSS build 

    Summary: this diff adds support for thrift in the OSS client build. it changes the `getdeps` airstore manifest to gain access to the thrift cpp2 compiler, then uses a rule similar to other projects to generate the cpp type headers. It changes the OSS `libbundle` library to depend on the thrift types introduced in D56578073 (and, through a lot of pain, get generated in the OSS build stack) which will then be used to ser/de bundles in the OSS build later in the stack!

Differential Revision: D56578071
    @codyohl @facebook-github-bot
    codyohl authored and facebook-github-bot committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    77292a4 View commit details
    Browse the repository at this point in the history