fix js exception due to regex flags #8887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: in ESTree, the `value` property of a regex is an instantiated `RegExp` object. if it can't be represented for some reason, the `value` should be `null`. there is also a `regex` property with the pattern and flags as strings so you can still tell what it was. JSON doesn't have regexes, so `flow ast` already returns null. `flow_parser.js` runs in a JS engine so it does try to create a `RegExp`. when creating a `RegExp` fatals, we previously tried to recover in a bogus way. it should return `null` instead. this fixes a crash when the browser engine doesn't support the latest regex flags, like `y`, `u` or `d`. Fixes facebook#8886 Changelog: [parser] Fix a runtime exception when parsing regexes via the JS version of the parser Differential Revision: D36754295 fbshipit-source-id: 18ed0bd17f1265a4da3e241e8f3b08fa5b15b722
|
This pull request was exported from Phabricator. Differential Revision: D36754295 |
|
I'm not sure if we have the same problem with |
|
looks like we don't even try to create a flow/src/parser/estree_translator.ml Line 1324 in c005082 filed #8888 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
in ESTree, the
valueproperty of a regex is an instantiatedRegExpobject. if it can't be represented for some reason, thevalueshould benull. there is also aregexproperty with the pattern and flags as strings so you can still tell what it was.JSON doesn't have regexes, so
flow astalready returns null.flow_parser.jsruns in a JS engine so it does try to create aRegExp. when creating aRegExpfatals, we previously tried to recover in a bogus way. it should returnnullinstead.this fixes a crash when the browser engine doesn't support the latest regex flags, like
y,uord.Fixes #8886
Changelog: [parser] Fix a runtime exception when parsing regexes via the JS version of the parser
Differential Revision: D36754295