chore: enforce LF line endings #8809
Conversation
| @@ -86,8 +86,8 @@ | |||
| "jest-coverage": "yarn jest --coverage", | |||
| "lint": "eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md", | |||
| "lint-es5-build": "eslint --no-eslintrc --no-ignore --env=browser packages/*/build-es5", | |||
| "lint:md": "yarn --silent lint:md:ci --fix", | |||
| "lint:md:ci": "prettylint '**/*.{md,yml,yaml}' --ignore-path .gitignore", | |||
| "lint:prettier": "yarn --silent lint:prettier:ci --fix", | |||
There was a problem hiding this comment.
Thought I'd also rename the script while on it since it's no longer just md. Simen mentioned this name being misleading some time ago.
| @@ -1,11 +1,17 @@ | |||
| # EditorConfig helps developers define and maintain consistent | |||
There was a problem hiding this comment.
Now this pretty much looks like the typical editorconfig examples, except for the md/snap override
|
Enforce LF from prettier config as well? Or does prettier read the editorconfig? |
|
Yes, prettier understands a few editorconfig settings https://prettier.io/docs/en/api.html#prettierresolveconfigfilepath-options |
|
(verified it by running |
|
Super! What do you think about a comment in editor config file to make the assumption explicit? |
|
@pedrottimark sure, why not - fine with that which I just added? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #8788.
Test plan
eslint-plugin-prettier/prettylintlint / autofix this for us.