Support RangeUntil operator #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ArchdukeTim! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
ArchdukeTim
force-pushed
the
supportRangeUntil
branch
2 times, most recently
from
debe6cf
to
2652473
Compare
|
Hi @ArchdukeTim! thanks, this looks good to me to merge, but you will need to sign the CLA first. |
|
Signed. Need to wait for propagation |
facebook-github-bot
added
the
CLA Signed
|
Any update on this? |
ArchdukeTim
force-pushed
the
supportRangeUntil
branch
from
2652473
to
ac9884e
Compare
|
@strulovich @ArchdukeTim is there anything holding this back from getting merged in? |
|
Sorry the delay @austinarbor. I'll pull your PR internally for review right away and will work with folks to get that merged in |
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thank you so much for the contribution @austinarbor! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary: Changelog: * Migrated to Google Java Format 1.22.0 (#440 and #452) * Added support for RangUntil (`..<`) operator (#433) * Trailing space issue on lambda blocks (#426) * Fix empty enum parse error (#425) * Preserving empty enums semicolons (#434) * Always use UTF8 (#437) * IntelliJI DEA plugin update (#420) * Managing trailing commas in enums (#449) * Badges on README (#446 and #453) * Emit parsing error for calls with multiple trailing lambdas (#457) * Removed duplicated line in editorconfig file (#456) Reviewed By: cortinico Differential Revision: D56467599 fbshipit-source-id: 10e90a34118267e36db80940f6a4e43aef89fbd3
github-merge-queue bot
pushed a commit
to slackhq/slack-gradle-plugin
that referenced
this pull request
Apr 27, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebookincubator/ktfmt) | dependencies | minor | `0.47` -> `0.49` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>facebookincubator/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49) #### Changelog - Stop emitting multiple trailing commas in enum entry lists with multiline items ([facebook/ktfmt#458) – [@​nreid260](https://togithub.com/nreid260) **Full Changelog**: facebook/ktfmt@v0.48...v0.49 ### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48): 0.48 Changelog: - Migrated to Google Java Format 1.22.0 ([facebook/ktfmt#440, [facebook/ktfmt#452) – [@​j-bahr](https://togithub.com/j-bahr), [@​nreid260](https://togithub.com/nreid260) - Added support for RangUntil (`..<`) operator ([facebook/ktfmt#433) – [@​ArchdukeTim](https://togithub.com/ArchdukeTim) - Trailing space issue on lambda blocks ([facebook/ktfmt#426) – [@​fredyw](https://togithub.com/fredyw), [@​hick209](https://togithub.com/hick209) - Fix empty enum parse error ([facebook/ktfmt#425) – [@​fredyw](https://togithub.com/fredyw) - Preserving empty enums semicolons ([facebook/ktfmt#434) – [@​nreid260](https://togithub.com/nreid260) - Always use UTF8 ([facebook/ktfmt#437) – [@​nreid260](https://togithub.com/nreid260) - IntelliJI DEA plugin update ([facebook/ktfmt#420) – [@​greyhairredbear](https://togithub.com/greyhairredbear) - Managing trailing commas in enums ([facebook/ktfmt#449) – [@​nreid260](https://togithub.com/nreid260) - Badges on README ([facebook/ktfmt#448, [facebook/ktfmt#453) – [@​JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba), [@​hick209](https://togithub.com/hick209) - Emit parsing error for calls with multiple trailing lambdas ([facebook/ktfmt#457) – [@​nreid260](https://togithub.com/nreid260) - Removed duplicated line in editorconfig file ([facebook/ktfmt#456) – [@​sabufung30](https://togithub.com/sabufung30) Big thanks to all the contributors! **Full Changelog**: facebook/ktfmt@v0.47...v0.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: Zac Sweers <pandanomic@gmail.com>
github-merge-queue bot
pushed a commit
to slackhq/circuit
that referenced
this pull request
Apr 28, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebook/ktfmt) | dependencies | minor | `0.47` -> `0.49` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>facebook/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49) #### Changelog - Stop emitting multiple trailing commas in enum entry lists with multiline items ([facebook/ktfmt#458) – [@​nreid260](https://togithub.com/nreid260) **Full Changelog**: facebook/ktfmt@v0.48...v0.49 ### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48): 0.48 Changelog: - Migrated to Google Java Format 1.22.0 ([facebook/ktfmt#440, [facebook/ktfmt#452) – [@​j-bahr](https://togithub.com/j-bahr), [@​nreid260](https://togithub.com/nreid260) - Added support for RangUntil (`..<`) operator ([facebook/ktfmt#433) – [@​ArchdukeTim](https://togithub.com/ArchdukeTim) - Trailing space issue on lambda blocks ([facebook/ktfmt#426) – [@​fredyw](https://togithub.com/fredyw), [@​hick209](https://togithub.com/hick209) - Fix empty enum parse error ([facebook/ktfmt#425) – [@​fredyw](https://togithub.com/fredyw) - Preserving empty enums semicolons ([facebook/ktfmt#434) – [@​nreid260](https://togithub.com/nreid260) - Always use UTF8 ([facebook/ktfmt#437) – [@​nreid260](https://togithub.com/nreid260) - IntelliJI DEA plugin update ([facebook/ktfmt#420) – [@​greyhairredbear](https://togithub.com/greyhairredbear) - Managing trailing commas in enums ([facebook/ktfmt#449) – [@​nreid260](https://togithub.com/nreid260) - Badges on README ([facebook/ktfmt#448, [facebook/ktfmt#453) – [@​JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba), [@​hick209](https://togithub.com/hick209) - Emit parsing error for calls with multiple trailing lambdas ([facebook/ktfmt#457) – [@​nreid260](https://togithub.com/nreid260) - Removed duplicated line in editorconfig file ([facebook/ktfmt#456) – [@​sabufung30](https://togithub.com/sabufung30) Big thanks to all the contributors! **Full Changelog**: facebook/ktfmt@v0.47...v0.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: Zac Sweers <pandanomic@gmail.com>
ZacSweers
added a commit
to ZacSweers/CatchUp
that referenced
this pull request
Apr 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebook/ktfmt) | `0.47` -> `0.49` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>facebook/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49) #### Changelog - Stop emitting multiple trailing commas in enum entry lists with multiline items ([facebook/ktfmt#458) – [@​nreid260](https://togithub.com/nreid260) **Full Changelog**: facebook/ktfmt@v0.48...v0.49 ### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48): 0.48 Changelog: - Migrated to Google Java Format 1.22.0 ([facebook/ktfmt#440, [facebook/ktfmt#452) – [@​j-bahr](https://togithub.com/j-bahr), [@​nreid260](https://togithub.com/nreid260) - Added support for RangUntil (`..<`) operator ([facebook/ktfmt#433) – [@​ArchdukeTim](https://togithub.com/ArchdukeTim) - Trailing space issue on lambda blocks ([facebook/ktfmt#426) – [@​fredyw](https://togithub.com/fredyw), [@​hick209](https://togithub.com/hick209) - Fix empty enum parse error ([facebook/ktfmt#425) – [@​fredyw](https://togithub.com/fredyw) - Preserving empty enums semicolons ([facebook/ktfmt#434) – [@​nreid260](https://togithub.com/nreid260) - Always use UTF8 ([facebook/ktfmt#437) – [@​nreid260](https://togithub.com/nreid260) - IntelliJI DEA plugin update ([facebook/ktfmt#420) – [@​greyhairredbear](https://togithub.com/greyhairredbear) - Managing trailing commas in enums ([facebook/ktfmt#449) – [@​nreid260](https://togithub.com/nreid260) - Badges on README ([facebook/ktfmt#448, [facebook/ktfmt#453) – [@​JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba), [@​hick209](https://togithub.com/hick209) - Emit parsing error for calls with multiple trailing lambdas ([facebook/ktfmt#457) – [@​nreid260](https://togithub.com/nreid260) - Removed duplicated line in editorconfig file ([facebook/ktfmt#456) – [@​sabufung30](https://togithub.com/sabufung30) Big thanks to all the contributors! **Full Changelog**: facebook/ktfmt@v0.47...v0.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ZacSweers/CatchUp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Zac Sweers <pandanomic@gmail.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424