Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated line in editorconfig for dropbox style #456

Closed
wants to merge 1 commit into from

Conversation

sabufung30
Copy link
Contributor

Remove ij_java_names_count_to_use_import_on_demand = 9999 in .editorconfig-dropbox

Remove duplicated line in editorconfig
@facebook-github-bot
Copy link
Contributor

Hi @sabufung30!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hick209
Copy link
Contributor

hick209 commented Apr 15, 2024

@sabufung30 thank you so much for the contribution!

Before we move forward, could you please add more context on why this change is required?

@sabufung30
Copy link
Contributor Author

sabufung30 commented Apr 18, 2024

@sabufung30 thank you so much for the contribution!

Before we move forward, could you please add more context on why this change is required?

There will be warning because of the duplicated config from IDE. Line 15 and 66 are identical

@hick209
Copy link
Contributor

hick209 commented Apr 18, 2024

Oof, sorry I missed that. Thanks for the fix 😃

@facebook-github-bot
Copy link
Contributor

@hick209 merged this pull request in 32bdde5.

facebook-github-bot pushed a commit that referenced this pull request Apr 23, 2024
Summary:
Changelog:
* Migrated to Google Java Format 1.22.0 (#440 and #452)
* Added support for RangUntil (`..<`) operator (#433)
* Trailing space issue on lambda blocks (#426)
* Fix empty enum parse error (#425)
* Preserving empty enums semicolons (#434)
* Always use UTF8 (#437)
* IntelliJI DEA plugin update (#420)
* Managing trailing commas in enums (#449)
* Badges on README (#446 and #453)
* Emit parsing error for calls with multiple trailing lambdas (#457)
* Removed duplicated line in editorconfig file (#456)

Reviewed By: cortinico

Differential Revision: D56467599

fbshipit-source-id: 10e90a34118267e36db80940f6a4e43aef89fbd3
github-merge-queue bot pushed a commit to slackhq/slack-gradle-plugin that referenced this pull request Apr 27, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [com.facebook:ktfmt](https://togithub.com/facebookincubator/ktfmt) |
dependencies | minor | `0.47` -> `0.49` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>facebookincubator/ktfmt (com.facebook:ktfmt)</summary>

### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49)

#### Changelog

- Stop emitting multiple trailing commas in enum entry lists with
multiline items
([facebook/ktfmt#458)
– [@&#8203;nreid260](https://togithub.com/nreid260)

**Full Changelog**:
facebook/ktfmt@v0.48...v0.49

### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48):
0.48

Changelog:

- Migrated to Google Java Format 1.22.0
([facebook/ktfmt#440,
[facebook/ktfmt#452)
– [@&#8203;j-bahr](https://togithub.com/j-bahr),
[@&#8203;nreid260](https://togithub.com/nreid260)
- Added support for RangUntil (`..<`) operator
([facebook/ktfmt#433)
– [@&#8203;ArchdukeTim](https://togithub.com/ArchdukeTim)
- Trailing space issue on lambda blocks
([facebook/ktfmt#426)
– [@&#8203;fredyw](https://togithub.com/fredyw),
[@&#8203;hick209](https://togithub.com/hick209)
- Fix empty enum parse error
([facebook/ktfmt#425)
– [@&#8203;fredyw](https://togithub.com/fredyw)
- Preserving empty enums semicolons
([facebook/ktfmt#434)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Always use UTF8
([facebook/ktfmt#437)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- IntelliJI DEA plugin update
([facebook/ktfmt#420)
– [@&#8203;greyhairredbear](https://togithub.com/greyhairredbear)
- Managing trailing commas in enums
([facebook/ktfmt#449)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Badges on README
([facebook/ktfmt#448,
[facebook/ktfmt#453)
–
[@&#8203;JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba),
[@&#8203;hick209](https://togithub.com/hick209)
- Emit parsing error for calls with multiple trailing lambdas
([facebook/ktfmt#457)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Removed duplicated line in editorconfig file
([facebook/ktfmt#456)
– [@&#8203;sabufung30](https://togithub.com/sabufung30)

Big thanks to all the contributors!

**Full Changelog**:
facebook/ktfmt@v0.47...v0.48

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: Zac Sweers <pandanomic@gmail.com>
github-merge-queue bot pushed a commit to slackhq/circuit that referenced this pull request Apr 28, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [com.facebook:ktfmt](https://togithub.com/facebook/ktfmt) |
dependencies | minor | `0.47` -> `0.49` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>facebook/ktfmt (com.facebook:ktfmt)</summary>

### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49)

#### Changelog

- Stop emitting multiple trailing commas in enum entry lists with
multiline items
([facebook/ktfmt#458)
– [@&#8203;nreid260](https://togithub.com/nreid260)

**Full Changelog**:
facebook/ktfmt@v0.48...v0.49

### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48):
0.48

Changelog:

- Migrated to Google Java Format 1.22.0
([facebook/ktfmt#440,
[facebook/ktfmt#452)
– [@&#8203;j-bahr](https://togithub.com/j-bahr),
[@&#8203;nreid260](https://togithub.com/nreid260)
- Added support for RangUntil (`..<`) operator
([facebook/ktfmt#433)
– [@&#8203;ArchdukeTim](https://togithub.com/ArchdukeTim)
- Trailing space issue on lambda blocks
([facebook/ktfmt#426)
– [@&#8203;fredyw](https://togithub.com/fredyw),
[@&#8203;hick209](https://togithub.com/hick209)
- Fix empty enum parse error
([facebook/ktfmt#425)
– [@&#8203;fredyw](https://togithub.com/fredyw)
- Preserving empty enums semicolons
([facebook/ktfmt#434)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Always use UTF8
([facebook/ktfmt#437)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- IntelliJI DEA plugin update
([facebook/ktfmt#420)
– [@&#8203;greyhairredbear](https://togithub.com/greyhairredbear)
- Managing trailing commas in enums
([facebook/ktfmt#449)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Badges on README
([facebook/ktfmt#448,
[facebook/ktfmt#453)
–
[@&#8203;JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba),
[@&#8203;hick209](https://togithub.com/hick209)
- Emit parsing error for calls with multiple trailing lambdas
([facebook/ktfmt#457)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Removed duplicated line in editorconfig file
([facebook/ktfmt#456)
– [@&#8203;sabufung30](https://togithub.com/sabufung30)

Big thanks to all the contributors!

**Full Changelog**:
facebook/ktfmt@v0.47...v0.48

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: Zac Sweers <pandanomic@gmail.com>
ZacSweers added a commit to ZacSweers/CatchUp that referenced this pull request Apr 29, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.facebook:ktfmt](https://togithub.com/facebook/ktfmt) | `0.47` ->
`0.49` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.facebook:ktfmt/0.49?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.facebook:ktfmt/0.49?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.facebook:ktfmt/0.47/0.49?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.facebook:ktfmt/0.47/0.49?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>facebook/ktfmt (com.facebook:ktfmt)</summary>

### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49)

#### Changelog

- Stop emitting multiple trailing commas in enum entry lists with
multiline items
([facebook/ktfmt#458)
– [@&#8203;nreid260](https://togithub.com/nreid260)

**Full Changelog**:
facebook/ktfmt@v0.48...v0.49

### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48):
0.48

Changelog:

- Migrated to Google Java Format 1.22.0
([facebook/ktfmt#440,
[facebook/ktfmt#452)
– [@&#8203;j-bahr](https://togithub.com/j-bahr),
[@&#8203;nreid260](https://togithub.com/nreid260)
- Added support for RangUntil (`..<`) operator
([facebook/ktfmt#433)
– [@&#8203;ArchdukeTim](https://togithub.com/ArchdukeTim)
- Trailing space issue on lambda blocks
([facebook/ktfmt#426)
– [@&#8203;fredyw](https://togithub.com/fredyw),
[@&#8203;hick209](https://togithub.com/hick209)
- Fix empty enum parse error
([facebook/ktfmt#425)
– [@&#8203;fredyw](https://togithub.com/fredyw)
- Preserving empty enums semicolons
([facebook/ktfmt#434)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Always use UTF8
([facebook/ktfmt#437)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- IntelliJI DEA plugin update
([facebook/ktfmt#420)
– [@&#8203;greyhairredbear](https://togithub.com/greyhairredbear)
- Managing trailing commas in enums
([facebook/ktfmt#449)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Badges on README
([facebook/ktfmt#448,
[facebook/ktfmt#453)
–
[@&#8203;JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba),
[@&#8203;hick209](https://togithub.com/hick209)
- Emit parsing error for calls with multiple trailing lambdas
([facebook/ktfmt#457)
– [@&#8203;nreid260](https://togithub.com/nreid260)
- Removed duplicated line in editorconfig file
([facebook/ktfmt#456)
– [@&#8203;sabufung30](https://togithub.com/sabufung30)

Big thanks to all the contributors!

**Full Changelog**:
facebook/ktfmt@v0.47...v0.48

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ZacSweers/CatchUp).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Zac Sweers <pandanomic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants