Skip to content

Commit

Permalink
Fix CircleCI: Node JS 14.17 is now the minimum supported version (#872)
Browse files Browse the repository at this point in the history
Summary:
CI tests are failing because [Jest 29](69607ae) introduces a dependency on Node `^14.15.0`. This updates our CI setup to Node 14, and in particular Node `^14.17.0`, which is the minimum version of Node 14 supported by ESLint.

Also take the opportunity to switch from `circleci` (legacy convenience image) to `cimg` (convenience image), as [recommended](https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034).

Pull Request resolved: #872

Test Plan: CircleCI

Reviewed By: jacdebug, motiz88

Differential Revision: D39690629

Pulled By: robhogan

fbshipit-source-id: 1503c340be524f88b67d82dc354cb8164a06c23c
  • Loading branch information
robhogan authored and facebook-github-bot committed Sep 21, 2022
1 parent c2365bb commit 956497f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions circle.yml
Expand Up @@ -36,7 +36,7 @@ version: 2.1
jobs:
run-js-checks:
docker:
- image: circleci/node:12
- image: cimg/node:14.17
steps:
- checkout
- yarn_install
Expand All @@ -46,9 +46,9 @@ jobs:
command: test-smoke


test-node-12:
test-node-14:
docker:
- image: circleci/node:12
- image: cimg/node:14.17
steps:
- checkout
- yarn_install
Expand All @@ -57,7 +57,7 @@ jobs:

publish-to-npm:
docker:
- image: circleci/node:12
- image: cimg/node:lts
steps:
- checkout
- yarn_install
Expand All @@ -71,7 +71,7 @@ workflows:
build-and-deploy:
jobs:
- run-js-checks
- test-node-12
- test-node-14
- publish-to-npm:
filters:
branches:
Expand Down

0 comments on commit 956497f

Please sign in to comment.