Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metro-minify-uglify #1013

Closed
wants to merge 1 commit into from
Closed

Commits on Jun 24, 2023

  1. Remove metro-minify-uglify

    Summary:
    `metro-minify-terser` has been Metro's default JS minifier since Metro [0.73.0](https://github.com/facebook/metro/releases/tag/v0.73.0) (facebook#871). However, we have continued to publish the deprecated `metro-minify-uglify` and included it in `metro`'s dependencies for a time for convenience.
    
    (Consequently, package managers have displayed a confusing warning for the use of the deprecated `uglify-es`, even when it isn't actually used.)
    
    This PR removes `metro-minify-uglify` from the main branch and from `metro`'s dependencies. If any critical patches are required in future, they may be published from the `0.76.x` branch.
    
    Users wishing to use `metro-minify-uglify` as of the latest version published may still do so by adding `metro-minify-uglify@^0.76.0` to their project's dependencies and configuring [`transformer.minifierPath`](https://facebook.github.io/metro/docs/configuration/#minifierpath):
    ```
    minifierPath: require.resolve('metro-minify-uglify')
    ```
    
    Changelog:
    ```
     - **[Breaking]**: Remove `metro-minify-uglify` from `metro` dependencies.
    ```
    
    Differential Revision: D47000809
    
    fbshipit-source-id: 3720c00c02cfa02e9c5c36f842708d16a48bccb5
    robhogan authored and facebook-github-bot committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    e63500c View commit details
    Browse the repository at this point in the history