Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add require.context support #822

Closed
wants to merge 43 commits into from
Closed

feat: add require.context support #822

wants to merge 43 commits into from

Commits on May 28, 2022

  1. feat: add resolveContext method for matching files

    @EvanBacon
    EvanBacon committed May 28, 2022
    Configuration menu
    Copy the full SHA
    d37ca65 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Moti Zilberman <motiz88@gmail.com>
    @EvanBacon @motiz88
    EvanBacon and motiz88 committed May 28, 2022
    Configuration menu
    Copy the full SHA
    faf5df7 View commit details
    Browse the repository at this point in the history

  3. Update HasteFS.js

    @EvanBacon
    EvanBacon committed May 28, 2022
    Configuration menu
    Copy the full SHA
    87bf0af View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Update HasteFS.js

    @EvanBacon
    EvanBacon committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    0d59e7f View commit details
    Browse the repository at this point in the history

  2. Add require context changes

    @EvanBacon
    EvanBacon committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    5852acb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into @evanbacon/require-context/resolve-file-paths

    @EvanBacon
    EvanBacon committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    12fcb4c View commit details
    Browse the repository at this point in the history

  4. Add all require.context changes

    @EvanBacon
    EvanBacon committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    360ee19 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Merge branch 'main' into @evanbacon/require-context/resolve-file-paths

    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    f9a84b0 View commit details
    Browse the repository at this point in the history

  2. pr feedback 

    revert broken feedback

Updated comment

Added tests for HasteFS

Update HasteFS-test.js

Add contextModuleTemplates tests

fixup types

Update index.js

Drop getTransformFn

drop unused

Update types.flow.js

Added more tests

inputPath -> from

Test require.context

fixup
    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    7b78806 View commit details
    Browse the repository at this point in the history

  3. Move buffer sha upstream

    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    1b807f3 View commit details
    Browse the repository at this point in the history

  4. fix types

    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    797a92c View commit details
    Browse the repository at this point in the history

  5. fix lint

    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    6f795ac View commit details
    Browse the repository at this point in the history

  6. normalize matching file patterns

    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    0cd6a1f View commit details
    Browse the repository at this point in the history

  7. fix lint

    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    b8336fd View commit details
    Browse the repository at this point in the history

  8. revert changes

    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    645443b View commit details
    Browse the repository at this point in the history

  9. fix tests

    @EvanBacon
    EvanBacon committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    6e25851 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. move sha1 back up

    @EvanBacon
    EvanBacon committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    ec0ac71 View commit details
    Browse the repository at this point in the history

  2. rename function

    @EvanBacon
    EvanBacon committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    2b59675 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Update Transformer-test.js

    @EvanBacon
    EvanBacon committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    182b4e8 View commit details
    Browse the repository at this point in the history

  2. restructure to use privateState 

    fixup

fix tests

Update graphOperations.js

Update DeltaCalculator-test.js
    @EvanBacon
    EvanBacon committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    2baf25d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. added tests

    @EvanBacon
    EvanBacon committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    5f110e6 View commit details
    Browse the repository at this point in the history

  2. Update traverseDependencies-test.js

    @EvanBacon
    EvanBacon committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    063e99a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. resolvedContexts

    @EvanBacon
    EvanBacon committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    4b965fb View commit details
    Browse the repository at this point in the history

  2. Update graphOperations.js

    @EvanBacon
    EvanBacon committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    56c6a66 View commit details
    Browse the repository at this point in the history

  3. Overhaul traverseDependencies tests, some API/behaviour changes 

    * getContextModulesMatchingFilePath --> markModifiedContextModules, taking a mutable Set
* resolvedContext --> resolveContexts
* transformer now consistently receives the absolute path
* fixed resolvedContexts deletion bug and added a regression test
* removed absolutePath from RequireContext type
* Flow check succeeds
* Tests no longer reach into privateState
    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9d469a5 View commit details
    Browse the repository at this point in the history

  4. Merge branch '@evanbacon/require-context/resolve-file-paths' of https… 

    …://github.com/EvanBacon/metro into @evanbacon/require-context/resolve-file-paths
    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b88384a View commit details
    Browse the repository at this point in the history

  5. Fix getTransformFn after absolute path change

    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c66d112 View commit details
    Browse the repository at this point in the history

  6. Add require.context integration test

    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    7e4308e View commit details
    Browse the repository at this point in the history

  7. Make order of keys in context module deterministic

    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    0795f6c View commit details
    Browse the repository at this point in the history

  8. Add integration test for require and context with the same first arg

    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    ec46ce0 View commit details
    Browse the repository at this point in the history

  9. Remove contextParams from Module type and processModule args

    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    2550dc8 View commit details
    Browse the repository at this point in the history

  10. Tighten incremental edge cases + add more tests

    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    d96a3bc View commit details
    Browse the repository at this point in the history

  11. Fix order sensitive test snapshot

    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    e05634f View commit details
    Browse the repository at this point in the history

  12. Add some line breaks to context module template

    @motiz88
    motiz88 committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    a7dd372 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Merge remote-tracking branch 'upstream/main' into @evanbacon/require-… 

    …context/resolve-file-paths
    @motiz88
    motiz88 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    7600f9e View commit details
    Browse the repository at this point in the history

  2. Fix up types post Flow upgrade 

    Flow was having some trouble with jest.fn(), added annotations to fix
    @motiz88
    motiz88 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    6bf2b5a View commit details
    Browse the repository at this point in the history

  3. id --> debugId, add tests

    @motiz88
    motiz88 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    4aae435 View commit details
    Browse the repository at this point in the history

  4. Remove debugId, getContextModuleId

    @motiz88
    motiz88 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    2172d42 View commit details
    Browse the repository at this point in the history

  5. Rewrite DeltaCalculator context tests and fix bugs

    @motiz88
    motiz88 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    612562c View commit details
    Browse the repository at this point in the history

  6. Light cleanup + file header fixes

    @motiz88
    motiz88 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    6404eb0 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Update HasteFS.js

    @EvanBacon
    EvanBacon committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    6833b44 View commit details
    Browse the repository at this point in the history

  2. PR Feedback

    @EvanBacon
    EvanBacon committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    49b97a3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into @evanbacon/require-context/resolve-file-paths

    @motiz88
    motiz88 committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    fbaf8bb View commit details
    Browse the repository at this point in the history