Group impl support #200
Merged
Group impl support #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
commented
Jul 6, 2021
daxpedda
commented
Jul 6, 2021
|
Clippy is currently broken because of rust-lang/rust-clippy#7422. |
kevinlewi
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groupfor bothPublicKeyandPrivateKeyGroup::Scalarnow requiresCopyGroup::scalar_as_bytesnow takes and returns a value instead of a referenceGroup::hash_to_curvenow returns aResultmap_to_curve::expand_message_xmdThere are quiet a bit of breaking changes, I didn't expect me doing this now, but it turned out that P256 is more important then we thought for our needs. I'm open to any suggestions.
Fixes #198.