Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Performance.md #11793

Closed
wants to merge 1 commit into from
Closed

Update Performance.md #11793

wants to merge 1 commit into from

Conversation

mikestek
Copy link

@mikestek mikestek commented Jan 9, 2017

Removed information about babel plugin that does not work with current version of RN

Removed information about babel plugin that does not work with current version of RN
@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @sunnylqm and @mkonicek to be potential reviewers.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 9, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mkonicek
Copy link
Contributor

mkonicek commented Feb 1, 2017

Why doesn't it work? Do you have a link to a source showing why it's not working?

@mikestek
Copy link
Author

mikestek commented Feb 1, 2017

#10412
shows others have been unable to get it working. I spent a while without being able to make release builds before was able to track down that the babel plugin was the issue, since I didn't think of checking something that was recommended by the official documentation first. So it shouldn't be in documentation if it doesn't work.

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. labels Apr 18, 2017
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@javache
Copy link
Member

javache commented Apr 18, 2017

Can you rebase and resolve conflicts?

@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Apr 19, 2017
@javache
Copy link
Member

javache commented Jun 6, 2017

This pull request has been inactive for a while and the last comments are questions or there have been changes requested.

I'll close the pull request so it doesn't stay open indefinitely. If you plan to continue working on this please send a new pull request.

@javache javache closed this Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants