Update eslint-config dependencies

[friederbluemle]

Summary

A couple of minor and patch updates to the eslint-config package, to avoid warnings and errors with the generated code of the latest RN version templates, such as:

warning "@react-native-community/eslint-config > eslint-plugin-react@7.12.4" has incorrect peer dependency "eslint@^3.0.0 || ^4.0.0 || ^5.0.0".
warning "@react-native-community/eslint-config > eslint-plugin-react-native@3.6.0" has incorrect peer dependency "eslint@^3.17.0 || ^4 || ^5".

yarn check outputs the following errors:

error "@react-native-community/eslint-config#eslint-plugin-react-native#eslint@^3.17.0 || ^4 || ^5" doesn't satisfy found match of "eslint@6.6.0"
error "@react-native-community/eslint-config#eslint-plugin-react#eslint@^3.0.0 || ^4.0.0 || ^5.0.0" doesn't satisfy found match of "eslint@6.6.0"

By adding the missing "license" field, from now on this also avoids the following warnings:

warning package.json: No license field
warning @react-native-community/eslint-config@0.0.6: No license field

Changelog

[General] [Fixed] - Fix eslint-config peer dependency warnings

Test Plan

• Publish current master package locally (0.0.6 is not published yet!)
• Create new RN 0.61.3 project, set eslint-config to local package, observe errors/warnings running yarn/yarn check
• yarn lint passes cleanly
• Update dependencies (as in this PR), republish locally
• Update RN test project to new eslint-config package, observe no more errors
• yarn lint still passes cleanly

[cpojer]

Thanks! Let me try to land this at FB.

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @friederbluemle in 1353da5.

^{When will my fix make it into a release? | Upcoming Releases}

[relign]

Thanks for update, babel-eslint@10.0.1 depend on eslint-scope@3.7.1, It causes the following problems:
eslint/eslint#12117
eslint/eslint#12055
And I think this fix can be reflected in the commit.

[friederbluemle]

@relign - Sorry can you clarify what you mean by "can be reflected in the commit"?

As of today, 10.0.3 is the latest version of babel-eslint. If it depends on an outdated eslint-scope, then babel-eslint needs to be updated.

[relign]

@friederbluemle I think the update of babel-eslint solve these issue, should be mentioned in changelog. It can be easily find by developer.

[fabianbru]

When will version 0.0.6 of @react-native-community/eslint-config package released? Thought it will be live with RN 0.61.5... but it's still 0.0.5

[friederbluemle]

@fabianbru - That's a great question. Note also that a new version of @react-native-community/eslint-config has not been published yet. So likely not before 0.62.

Maybe @TheSavior, @michalchudziak or @matt-oakes has more information?

[matt-oakes]

@friederbluemle As far as I know, the ESLint package is not tied to a React Native release cycle and can be released at any time. I think someone just needs to run the release command manually on their machine.

[TheSavior]

@hramos do you know how to do a release of this package?

[cpojer]

@TheSavior just npm publish it.

[zfoltin]

@matt-oakes could you do the honours, please? it looks like it's just you and mike866 who are collaborators on https://www.npmjs.com/package/@react-native-community/eslint-config

[matt-oakes]

I think that's done.

Really, this should be moved to the react-native-community organisation so it's easier to maintain and release. However, I seem to remember there being some issues internally at Facebook as to why that can't happen. Is that still correct @cpojer?

[cpojer]

@matt-oakes the reason I would prefer keeping it within the RN repo is that we actually use this config within RN and within FB. Externalizing it to another repo on GitHub will make our setup more complex.

[matt-oakes]

@cpojer I think that makes sense. Maybe there needs to be a better process for ensuring changes to the config actually end up being published once a PR lands? I'm not sure what that process would actually be though. Maybe you could add me to the CODE_OWNERS file for this package so I get alerted to any PRs which relate to the package?

[cpojer]

Sounds great, do you mind sending a PR?

[matt-oakes]

@cpojer PR opened here #27689