Commits on Jun 4, 2021

1. Use Node v14 in Windows CircleCI jobs (facebook#31656) …

   Summary:
   Pull Request resolved: facebook#31656
   
   CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following facebook#30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line.
   
   Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we pin a v14 release that is currently the most recent LTS version.
   
   NOTE: The nvm on CircleCI is https://github.com/coreybutler/nvm-windows, not https://github.com/nvm-sh/nvm, and the two aren't interchangeable. [nvm-windows has no functionality to install the latest version of a release line](coreybutler/nvm-windows#156) so we're forced to specify an exact version, which will need to be bumped manually in the future. This isn't great, but IMO it's no worse than the current situation, where we use whichever stale version of Node happens to be bundled with the Windows CircleCI executor.
   
   Changelog:
   [Internal]
   
   Differential Revision: D28896581
   
   fbshipit-source-id: abf3b56a256f89374add1c01ae6b99a8ba234112

   

   motiz88 authored and facebook-github-bot committed Jun 4, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for a8cd790
   • Browse repository at this point

   Copy the full SHA

   a8cd790 View commit details

   Browse the repository at this point in the history