Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest): bump jest to 29 in the template #34972

Closed
wants to merge 1 commit into from
Closed

feat(jest): bump jest to 29 in the template #34972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions template/package.json
View file
Open in desktop
Expand Up @@ -17,9 +17,9 @@
"@babel/core": "^7.12.9",
"@babel/runtime": "^7.12.5",
"@react-native-community/eslint-config": "^3.0.0",
"babel-jest": "^26.6.3",
"babel-jest": "^29.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just released 29.2.0 fwiw. But I guess these versions mirror some internal version and should remain in sync with that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I want to keep the versioning consistent across the entire repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping them consistent makes sense, but I would like to bump all of them to at least 29.1.0 before 0.71, because jest.now() is important for properly mocking (legacy) fake timer animations.

I'll pull this in and then have a go at bumping internally across the monorepo. Should be smooth, right? 🤞

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully! 😀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will :) just need a few mins to push a change in the other PR then they should be good to go 👍

"eslint": "^8.19.0",
"jest": "^26.6.3",
"jest": "^29.0.3",
"metro-react-native-babel-preset": "0.72.3",
"react-test-renderer": "18.2.0"
},
Expand Down