fix: do not render mocked Modal when visible=false #39157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Base commit: 3c87455 |
|
The failure in test_e2e_android check does not seem to be related to this PR. |
mdjastrzebski
force-pushed
the
fix/modal-mock-render
branch
from
8e1332e
to
07f4ed3
Compare
lunaleaps
reviewed
Aug 25, 2023
| @@ -13,7 +13,7 @@ exports[`<Modal /> should render as <RCTModalHostView> when not mocked 1`] = ` | |||
| <RCTModalHostView | |||
| animationType="none" | |||
| hardwareAccelerated={false} | |||
| identifier={4} | |||
There was a problem hiding this comment.
What caused this to change?
There was a problem hiding this comment.
I happens due to Modal keeping auto-incrementing identifier for each composite Modal instance. Since tests are not isolated, the removal of rendering of Modal when visible={false} in previous test reduced the count by 1.
lunaleaps
approved these changes
Aug 28, 2023
lunaleaps
approved these changes
Aug 28, 2023
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @mdjastrzebski in 468a136. When will my fix make it into a release? | Upcoming Releases |
|
@lunaleaps merged this pull request in 468a136. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Note: this PR is related only to testing mocks provided by RN, and does not affect runtime code.
When building new Jest matchers for React Native Testing Library (callstack/react-native-testing-library#1468) I've noticed that when rendering React Native in Jest using React Test Renderer the mocked
Modalcomponent renders hostModalelement whenvisible={false}.This seems to be incorrect as only visible modal should render any host elements. Not visible one should not render any host element even empty ones. Current mock implementation also contradicts the behaviour of non-mocked
Modalwhich does not renderRCTModalHostViewin such case.Changelog:
[General] [Fixed] - Do not render mocked when
visible=falseTest Plan:
I've added test showing that non-mocked Modal renders to
nulland modifies the existing tests so that mocked Modal also renders tonull.