Move Noop Module Test Helpers to top level entry points

This module has shared state. It needs to be external from builds. This lets us test the built versions of the Noop renderer.
facebook · Mar 24, 2020 · 19435d0 · 19435d0
1 parent 874eab1
commit 19435d0
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 4 deletions.
diff --git a/...er/src/ReactNoopFlightModuleTestHelper.js → ...ges/react-noop-renderer/flight-modules.js b/...er/src/ReactNoopFlightModuleTestHelper.js → ...ges/react-noop-renderer/flight-modules.js
diff --git a/packages/react-noop-renderer/npm/flight-modules.js b/packages/react-noop-renderer/npm/flight-modules.js
@@ -0,0 +1,16 @@
+'use strict';
+
+// This file is used as temporary storage for modules generated in Flight tests.
+var moduleIdx = 0;
+var modules = new Map();
+
+// This simulates what the compiler will do when it replaces render functions with server blocks.
+exports.saveModule = function saveModule(render) {
+  var idx = '' + moduleIdx++;
+  modules.set(idx, render);
+  return idx;
+};
+
+exports.readModule = function readModule(idx) {
+  return modules.get(idx);
+};
diff --git a/packages/react-noop-renderer/package.json b/packages/react-noop-renderer/package.json
@@ -28,6 +28,7 @@
     "persistent.js",
     "server.js",
     "flight-client.js",
+    "flight-modules.js",
     "flight-server.js",
     "cjs/"
   ]

diff --git a/packages/react-noop-renderer/src/ReactNoopFlightClient.js b/packages/react-noop-renderer/src/ReactNoopFlightClient.js
@@ -16,7 +16,7 @@
 
 import type {ReactModelRoot} from 'react-client/flight';
 
-import {readModule} from './ReactNoopFlightModuleTestHelper';
+import {readModule} from 'react-noop-renderer/flight-modules';
 
 import ReactFlightClient from 'react-client/flight';
 

diff --git a/packages/react-noop-renderer/src/ReactNoopFlightServer.js b/packages/react-noop-renderer/src/ReactNoopFlightServer.js
@@ -16,7 +16,7 @@
 
 import type {ReactModel} from 'react-server/src/ReactFlightServer';
 
-import {saveModule} from './ReactNoopFlightModuleTestHelper';
+import {saveModule} from 'react-noop-renderer/flight-modules';
 
 import ReactFlightServer from 'react-server/flight';
 

diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js
@@ -405,7 +405,12 @@ const bundles = [
     moduleType: RENDERER,
     entry: 'react-noop-renderer/flight-server',
     global: 'ReactNoopFlightServer',
-    externals: ['react', 'scheduler', 'expect'],
+    externals: [
+      'react',
+      'scheduler',
+      'expect',
+      'react-noop-renderer/flight-modules',
+    ],
   },
 
   /******* React Noop Flight Client (used for tests) *******/
@@ -414,7 +419,12 @@ const bundles = [
     moduleType: RENDERER,
     entry: 'react-noop-renderer/flight-client',
     global: 'ReactNoopFlightClient',
-    externals: ['react', 'scheduler', 'expect'],
+    externals: [
+      'react',
+      'scheduler',
+      'expect',
+      'react-noop-renderer/flight-modules',
+    ],
   },
 
   /******* React Reconciler *******/