New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTML5 Video Attribute disablePictureInPicture #15333
Comments
Is this a valid issue and is anyone working on it? I am a student at the University of Michigan looking to contribute to an open source project for my upper-level software engineering class. |
Looking at the W3C specification it doesn't seem like
We typically avoid adding attributes that are not standardized, unless they have widespread browser support. Do you know which browsers support |
@aweary - PiP is enabled by default since Chrome 70. Safari also has support but it's not enabled by default yet. Since Edge also moved to Chromium, probably Edge support as well soon. Full list here: https://caniuse.com/#feat=picture-in-picture For desktop usage, it's 62.31% (full support) with 7.97% (for partial support), so total usage is at 70.28% |
Needed to disable the PiP button before going live with a new feature this month, so to work around this issue, I call
on a ref of the ¯\(シ)/¯ https://w3c.github.io/picture-in-picture/#example-add-custom-pip-button |
adding "disablePictureInPicture controlsList="nodownload" " to video tag removes 3 dots in Full-screen mode |
Bug Report:
disablePictureInPicture
for html5 video elements are not supportedEg:
What is the current behavior?
Should remove the 3 dots (more button) on videos on Chrome:
What is the expected behavior?
Instead, the attribute is not taken into consideration so the more menu stays:
Example:
https://jsfiddle.net/r1w4x7m0/2/
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
All / Latest, Chrome Browsers, All OSes.
Pull request for this issue has also been submitted: #15334
The text was updated successfully, but these errors were encountered: