Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using reactjs.org instead of fb.me in react's error/warning messages #16109

Closed
dehghani-mehdi opened this issue Jul 11, 2019 · 16 comments · Fixed by #19830
Closed

Consider using reactjs.org instead of fb.me in react's error/warning messages #16109

dehghani-mehdi opened this issue Jul 11, 2019 · 16 comments · Fixed by #19830

Comments

@dehghani-mehdi
Copy link

dehghani-mehdi commented Jul 11, 2019

Hi,

Facebook is blocked in my country (and I think in some other countries) and links like https://fb.me/react-invalid-hook-call are blocked for me, in order to see the related documentation of the link I have to use VPN. so if is possible please use another link shortener service or point to reactjs.org directly.

Thanks.

@threepointone
Copy link
Contributor

We are considering this seriously. We are not sure when and how we'll do this, but it's on our minds. Thanks for the suggestion!

@bencefr
Copy link

bencefr commented Dec 10, 2019

One more reason is that current links require fb account! Please make this priority.

@stale
Copy link

stale bot commented Mar 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Mar 9, 2020
@threepointone
Copy link
Contributor

Not stale, I think we do want to do this sometime.

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Mar 9, 2020
@threepointone
Copy link
Contributor

@bencefr I don’t think you’re right? Definitely does not require an fb account

@bencefr
Copy link

bencefr commented Mar 10, 2020

@threepointone , it definitely does, since fb.me/... just redirects to facebook.com main page to sign up.

@dehghani-mehdi
Copy link
Author

@bencefr I just tested https://fb.me/react-invalid-hook-call and it redirects me to https://reactjs.org/warnings/invalid-hook-call-warning.html without forcing me to log in into my facebook account.

@bencefr
Copy link

bencefr commented Mar 10, 2020

My bad, the link I used had a typo and should have been a 404. The redirect works but I would be against using fb.me anyway.

@threepointone
Copy link
Contributor

More data for this, fb.me is blocked inside lots of corporate environments as it's considered "social networking". While I'm working on getting it unblocked in my own firm, I don't expect that to actually happen soon.

@val1984
Copy link

val1984 commented Aug 12, 2020

McAfee's TrustedSource categorizes fb.me as "Social Networking" which is enough for my company to block it. I tried to make them change this categorization to "Internet Services" (like bit.ly) but so far I haven't been successful, probably because fb.me (or any non-existing shortcut like fb.me/trololololololilol) redirects to facebook.com.
I will try to make it unblocked but I have little hope so having reactjs.org urls in logs would be an improvement.

@tebeco
Copy link

tebeco commented Aug 12, 2020

I can't agree more with @val1984
This probably would help tons of developper working within company with gateway (McAfee is just one of the many existing ones)
Having a dedicated FQDN like reactjs.org is something that can be trusted
Using fb.me will never be whitelisted for many reason like redirect to facebook / analytics / etc ...

We are considering this seriously. We are not sure when and how we'll do this, but it's on our minds. Thanks for the suggestion!

@threepointone how did it go ?

@cylim
Copy link
Contributor

cylim commented Aug 13, 2020

@threepointone @gaearon
Sorry, my bad for creating the PR directly without asking. I was thinking about better to have working warning than waiting for perfect solution.

Redirect links might redirect to invalid links too, one of the example is fb.me/react-mock-scheduler

I would suggest to create something like _redirects netlify, so that the public contributors can helps to update/monitoring the links whether needed.

@gaearon
Copy link
Collaborator

gaearon commented Aug 13, 2020

No worries. We appreciate the intent — it’s just unfortunate because that particular change isn’t something we can do.

I think your proposal with _redirect makes sense. Is this something you would be interested in implementing?

@cylim
Copy link
Contributor

cylim commented Aug 13, 2020

@gaearon Yes. I am happy to do it.

I can see that reactjs.org is hosting on Netlify, and it is already _redirects using in reactjs.org website _redirects on reactjs.org.

Any preferred path for the short link?
reactjs.org/{path}/{title}

I can start with link as the path, it can be change easily later on.

@gaearon
Copy link
Collaborator

gaearon commented Aug 17, 2020

Thanks to @cylim for taking this issue and spending the time to solve it.

reactjs/react.dev#3199
#19598

This will go out in 17.

@gaearon gaearon closed this as completed Aug 17, 2020
@tebeco
Copy link

tebeco commented Aug 17, 2020

Thx a lot for this @cylim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants