Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor fb.me redirect link to original link #19593

Closed
wants to merge 1 commit into from

Conversation

cylim
Copy link
Contributor

@cylim cylim commented Aug 12, 2020

Summary

ref #16109

The reason for these quick changes is to allow developers from countries or corporations that blocked Facebook(Social Media) to view error/warning messages in detail.

Issues

  1. I did not fix the link https://fb.me/react-mock-scheduler due to it is an invalid link and it related to Experiment features.
  2. It will be better to use another short link redirect tool because some links are gist, GitHub issues, and some links are pretty long.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5ab87c2:

Sandbox Source
React Configuration

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the intent, but it would be good to discuss the plan before making the change.
In particular, we definitely do not want to hardcode specific paths into warnings since they may go 404 eventually.

Instead, what we should do is add a redirect path to the website itself (e.g. https://reactjs.org/link/<...>) and then port to those.

@cylim cylim closed this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants