Fix allowTransparency in the attribute table #10817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Sep 25, 2017
| | `allowTransparency=(function)`| (initial, warning, ssr mismatch)| `<null>` | | ||
| | `allowTransparency=(null)`| (initial)| `<null>` | | ||
| | `allowTransparency=(undefined)`| (initial)| `<null>` | | ||
| ## `allowTransparency` (on `<div>`) |
There was a problem hiding this comment.
Oops, looks like we print a container name instead of the tag name. Will send a separate fix.
There was a problem hiding this comment.
Maybe I didn't understand your comment, but should this be (on <iframe>)?
There was a problem hiding this comment.
Yes, that was my original intention. See #10818
nhunzaker
approved these changes
Sep 25, 2017
|
Okay, found a handy test page! http://samples.msdn.microsoft.com/workshop/samples/author/dhtml/refs/allowTransparency.htm I think we can remove allowTransparency. It looks like it went away with IE9. IE7
IE8
IE9
Chrome
Safari
|
|
Haha let's do it then. PR? |
|
Haha, sure thing. |
|
Done in #10823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not sure if this was intentional, but
allowTransparencyis not an SVG attribute.It’s an IE-only
iframeattribute. So it’s expected that Chrome wouldn’t recognize it.Not sure if that’s useful though, as now instead of testing the wrong thing we’re not testing anything at all. 😄