Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate findDOMNode in StrictMode #13841

Merged
merged 4 commits into from
Oct 12, 2018
Merged

Deprecate findDOMNode in StrictMode #13841

merged 4 commits into from
Oct 12, 2018

Commits on Oct 12, 2018

  1. Deprecate findDOMNode in StrictMode 

    There are two scenarios. One is that we pass a component instance that is
already in strict mode or the node that we find is in strict mode if
an outer component renders into strict mode.

I use a separate method findHostInstanceWithWarning for this so that
a) I can pass the method name (findDOMNode/findNodeHandle).
b) Can ignore this warning in React Native mixins/NativeComponent that use this helper.

I don't want to expose the fiber to the renderers themselves.
    @sebmarkbage
    sebmarkbage committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    8ba0db9 View commit details
    Browse the repository at this point in the history

  2. Update warning message

    @sebmarkbage
    sebmarkbage committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    42caeed View commit details
    Browse the repository at this point in the history

  3. Use full stack even when the target argument is in strict

    @sebmarkbage
    sebmarkbage committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    9e6960d View commit details
    Browse the repository at this point in the history

  4. rm a

    @sebmarkbage
    sebmarkbage committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    665596c View commit details
    Browse the repository at this point in the history