include component stack in 'act(...)' warning #14855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
changed the title
gaearon
reviewed
Feb 14, 2019
| @@ -1815,8 +1815,9 @@ export function warnIfNotCurrentlyBatchingInDev(fiber: Fiber): void { | |||
| '});\n' + | |||
| '/* assert on the output */\n\n' + | |||
| "This ensures that you're testing the behavior the user would see in the browser." + | |||
| ' Learn more at https://fb.me/react-wrap-tests-with-act', | |||
| ' Learn more at https://fb.me/react-wrap-tests-with-act\n%s', | |||
There was a problem hiding this comment.
Is this newline necessary? I thought stack starts with a newline.
There was a problem hiding this comment.
fair, removed.
gaearon
approved these changes
Feb 14, 2019
This was referenced Aug 12, 2019
This was referenced Aug 20, 2019
This was referenced Aug 27, 2019
This was referenced Sep 20, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks aren't seeing stack traces for their calls in their jest setups, so this PR includes a component stack trace to make it easier to locate and wrap with
act(...).