New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn if passive effects get queued outside of an act() call. #15631
warn if passive effects get queued outside of an act() call. #15631
Commits on May 8, 2019
-
s/flushPassiveEffects/unstable_flushWithoutYielding
a first crack at flushing the scheduler manually from inside act(). uses unstable_flushWithoutYielding(). The tests that changes, mostly replaced toFlushAndYield(...) with toHaveYielded(). For some tests that tested the state of the tree before flushing effects (but still after updates), I replaced act() with bacthedUpdates().
Sunil Pai committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 0f1977a - Browse repository at this point
Copy the full SHA 0f1977aView commit details -
Sunil Pai committed
May 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 5e5a68b - Browse repository at this point
Copy the full SHA 5e5a68bView commit details -
pass build, flushPassiveEffects returns nothing now
Sunil Pai committedMay 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 37989a5 - Browse repository at this point
Copy the full SHA 37989a5View commit details
Commits on May 9, 2019
-
Sunil Pai committed
May 9, 2019 Configuration menu - View commit details
-
Copy full SHA for f5fd513 - Browse repository at this point
Copy the full SHA f5fd513View commit details -
flush all work (not just effects), add a compatibility mode
of note, unstable_flushWithoutYielding now returns a boolean much like flushPassiveEffects
Sunil Pai committedMay 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 5003233 - Browse repository at this point
Copy the full SHA 5003233View commit details -
umd build for scheduler/unstable_mock, pass the fixture with it
Sunil Pai committedMay 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 7de2164 - Browse repository at this point
Copy the full SHA 7de2164View commit details -
add a comment to Shcduler.umd.js for why we're exporting unstable_flu…
…shWithoutYielding
Sunil Pai committedMay 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 0287733 - Browse repository at this point
Copy the full SHA 0287733View commit details
Commits on May 11, 2019
-
run testsutilsact tests in both sync/concurrent modes
Sunil Pai committedMay 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 3966dcc - Browse repository at this point
Copy the full SHA 3966dccView commit details -
Sunil Pai committed
May 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 9f2d141 - Browse repository at this point
Copy the full SHA 9f2d141View commit details -
use a feature flag for the missing mock scheduler warning
I also tried writing a test for it, but couldn't get the scheduler to unmock. included the failing test.
Sunil Pai committedMay 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 6920e9f - Browse repository at this point
Copy the full SHA 6920e9fView commit details
Commits on May 12, 2019
-
warn if passive effects get queued outside of an act() call.
based on facebook#15591. of note, we don't modify our own tests to satisfy this warning, instead using a feature flag to disable the warning for some tests. this is because we're testing the actual sequencing of work in these tests, and don't want to flush everything with act().
Sunil Pai committedMay 12, 2019 Configuration menu - View commit details
-
Copy full SHA for 9f7a346 - Browse repository at this point
Copy the full SHA 9f7a346View commit details