Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn if passive effects get queued outside of an act() call. #15631

Commits on May 8, 2019

  1. s/flushPassiveEffects/unstable_flushWithoutYielding

    a first crack at flushing the scheduler manually from inside act(). uses unstable_flushWithoutYielding(). The tests that changes, mostly replaced toFlushAndYield(...) with toHaveYielded(). For some tests that tested the state of the tree before flushing effects (but still after updates), I replaced act() with bacthedUpdates().
    Sunil Pai committed May 8, 2019
    Configuration menu
    Copy the full SHA
    0f1977a View commit details
    Browse the repository at this point in the history
  2. ugh lint

    Sunil Pai committed May 8, 2019
    Configuration menu
    Copy the full SHA
    5e5a68b View commit details
    Browse the repository at this point in the history
  3. pass build, flushPassiveEffects returns nothing now

    Sunil Pai committed May 8, 2019
    Configuration menu
    Copy the full SHA
    37989a5 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. pass test-fire

    Sunil Pai committed May 9, 2019
    Configuration menu
    Copy the full SHA
    f5fd513 View commit details
    Browse the repository at this point in the history
  2. flush all work (not just effects), add a compatibility mode

    of note, unstable_flushWithoutYielding now returns a boolean much like flushPassiveEffects
    Sunil Pai committed May 9, 2019
    Configuration menu
    Copy the full SHA
    5003233 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7de2164 View commit details
    Browse the repository at this point in the history
  4. add a comment to Shcduler.umd.js for why we're exporting unstable_flu…

    …shWithoutYielding
    Sunil Pai committed May 9, 2019
    Configuration menu
    Copy the full SHA
    0287733 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2019

  1. Configuration menu
    Copy the full SHA
    3966dcc View commit details
    Browse the repository at this point in the history
  2. augh lint

    Sunil Pai committed May 11, 2019
    Configuration menu
    Copy the full SHA
    9f2d141 View commit details
    Browse the repository at this point in the history
  3. use a feature flag for the missing mock scheduler warning

    I also tried writing a test for it, but couldn't get the scheduler to unmock. included the failing test.
    Sunil Pai committed May 11, 2019
    Configuration menu
    Copy the full SHA
    6920e9f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2019

  1. warn if passive effects get queued outside of an act() call.

    based on facebook#15591. of note, we don't modify our own tests to satisfy this warning, instead using a feature flag to disable the warning for some tests. this is because we're testing the actual sequencing of work in these tests, and don't want to flush everything with act().
    Sunil Pai committed May 12, 2019
    Configuration menu
    Copy the full SHA
    9f7a346 View commit details
    Browse the repository at this point in the history