Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flush pending passive effects early on an interactive update #15644

Closed
wants to merge 2 commits into from
Closed

flush pending passive effects early on an interactive update #15644

wants to merge 2 commits into from

Conversation

threepointone
Copy link
Contributor

related to #15057

ported over Dan's PR from #15067 to discuss this.

  • is our recommendation to folks to use interactiveUpdates(() => {...}) for all 'outside' updates?
  • alternately, what should the OP code look like? this situation of 'do something when a value becomes something' comes up often. emitEffect?

@acdlite acdlite mentioned this pull request May 14, 2019
Merged
@threepointone
Copy link
Contributor Author

abandoning for #15650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@threepointone @facebook-github-bot