flush only on exiting outermost act() #15682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 9c6de71...94d7ffe react-dom
react-test-renderer
react-noop-renderer
Generated by 🚫 dangerJS |
Thanks! That makes it much easier for me to review, too. (Personally I find rebasing on master makes it easier to maintain stacked PRs, compared to merging, but if you prefer merging keep doing that.) |
acdlite
approved these changes
May 20, 2019
| @@ -171,7 +177,11 @@ function act(callback: () => Thenable) { | |||
|
|
|||
| // flush effects until none remain, and cleanup | |||
| try { | |||
| flushWork(); | |||
| if (actingUpdatesScopeDepth === 1) { | |||
There was a problem hiding this comment.
Nit:
Suggested change
| if (actingUpdatesScopeDepth === 1) { | |
| if (actingUpdatesScopeDepth <= 1) { |
There was a problem hiding this comment.
really? it shouldn't do that if it's 0 (and it ideally should never be 0 here). going to push back on this.
There was a problem hiding this comment.
tbh, it should probably throw an error if it ever gets there
robertknight
added a commit
to preactjs/preact
that referenced
this pull request
Aug 11, 2019
When calls to act are nested, effects and component updates are only flushed when the outer `act` call returns, as per [1] and [2]. This is convenient for creating helper functions which may invoke `act` themselves. [1] facebook/react#15682 [2] facebook/react#15472
robertknight
added a commit
to preactjs/preact
that referenced
this pull request
Aug 11, 2019
When calls to act are nested, effects and component updates are only flushed when the outer `act` call returns, as per [1] and [2]. This is convenient for creating helper functions which may invoke `act` themselves. [1] facebook/react#15682 [2] facebook/react#15472
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ like it says. we flush only on exiting the outermost act().
my previous PR (#15519) ended up in merge conflict hell, so I just redid it.