Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suspense] Use style.setProperty to set display #15882

Merged
merged 1 commit into from Jun 14, 2019

Commits on Jun 14, 2019

  1. [Suspense] Use style.setProperty to set display

    Follow up to facebook#15861.
    
    Turns out you can't set `!important` using a normal property assignment.
    You have to use `style.setProperty`.
    
    Maybe Andrew *should* just learn CSS.
    
    IE9 doesn't support `style.setProperty` so we'll fall back to setting
    `display: none` without `important`, like we did before facebook#15861 Our
    advice for apps that need to support IE9 will be to avoid using
    `!important`. Which seems like good advice in general, but IANACSSE.
    
    Tested on FB and using our Suspense DOM fixture.
    acdlite committed Jun 14, 2019
    Copy the full SHA
    338eab2 View commit details
    Browse the repository at this point in the history