Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly improve performance of hydration. #15998

Merged
merged 3 commits into from Jun 27, 2019
Merged

Slightly improve performance of hydration. #15998

merged 3 commits into from Jun 27, 2019

Commits on Jun 26, 2019

  1. Slightly improve performance of hydration. 

    Avoid loading nodeType and data couple times from the same node in a row,
but instead load them only once, which will help engines to run this code
faster, especially during startup of the application. The general approach
is still not ideal, since hydrating this way forces the browser engine
to materialize JavaScript wrapper objects for all DOM nodes, even if they
are not interesting to hydration itself.
    @bmeurer
    bmeurer committed Jun 26, 2019
    Copy the full SHA
    93a6a47 View commit details
    Browse the repository at this point in the history

  2. Fix condition for COMMENT_NODEs.

    @bmeurer
    bmeurer committed Jun 26, 2019
    Copy the full SHA
    5b24cfd View commit details
    Browse the repository at this point in the history

  3. Improve general code readability

    @bmeurer
    bmeurer committed Jun 26, 2019
    Copy the full SHA
    fba82af View commit details
    Browse the repository at this point in the history