Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fail] reset IsThisRendererActing correctly #16042

Merged
merged 2 commits into from Jul 3, 2019
Merged

[fail] reset IsThisRendererActing correctly #16042

merged 2 commits into from Jul 3, 2019

Commits on Jul 3, 2019

  1. [fail] reset IsThisRendererActing correctly 

    I missed this in facebook#16039. I'd pointed at the wrong previous state, corrupting it in further use. This PR fixes that, and adds a test to make sure it doesn't happen again.
    @threepointone
    threepointone committed Jul 3, 2019
    Copy the full SHA
    7ebb2e0 View commit details
    Browse the repository at this point in the history

  2. warn for unacted effects only in strict mode

    @threepointone
    threepointone committed Jul 3, 2019
    Copy the full SHA
    42149bf View commit details
    Browse the repository at this point in the history