Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify deprecated/unsafe lifecycle warnings, pass tests #16103

Merged
merged 1 commit into from Jul 15, 2019
Merged

unify deprecated/unsafe lifecycle warnings, pass tests #16103

merged 1 commit into from Jul 15, 2019

Commits on Jul 15, 2019

  1. unify deprecated/unsafe lifecycle warnings, pass tests 

    - redoes facebook#15431 from scratch, taking on the feedback there
- unifies the messaging between "deprecated" and UNSAFE_ lifecycle messages. It reorganizes ReactStrictModeWarnings.js to capture and flush all the lifecycle warnings in one procedure each.
- matches the warning from ReactPartialRenderer to match the above change
- passes all the tests
- this also turns on `warnAboutDeprecatedLifecycles` for the test renderer. I think we missed doing so it previously. In a future PR, I'll remove the feature flag altogether.
- this DOES NOT do the same treatment for context warnings, I'll do that in another PR too
    @threepointone
    threepointone committed Jul 15, 2019
    Copy the full SHA
    9505272 View commit details
    Browse the repository at this point in the history