Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hyphenate custom CSS properties for ReactDOMServer #16167

Merged
merged 8 commits into from Jul 26, 2019
Merged

Don't hyphenate custom CSS properties for ReactDOMServer #16167

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9dd75f6
Do not hyphenate custom CSS property
bedakb Jul 19, 2019
bd046c9
Move check into the processStyleName fn
bedakb Jul 20, 2019
b08743b
Formatting
bedakb Jul 20, 2019
63c4e82
add test
bedakb Jul 20, 2019
f510cff
Put isCustomProperty check after conditional return
bedakb Jul 20, 2019
34c5fb0
add test to `ReactDOMServerIntegration` and supress warning
bedakb Jul 20, 2019
39e5c12
Don't indexOf twice
gaearon Jul 26, 2019
071824c
Simpler fix
gaearon Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/react-dom/src/__tests__/CSSPropertyOperations-test.js
View file
Open in desktop
Expand Up @@ -57,6 +57,15 @@ describe('CSSPropertyOperations', () => {
expect(html).toContain('"-ms-transition:none;-moz-transition:none"');
});

it('should not hyphenate custom CSS property', () => {
const styles = {
'--someColor': '#000000',
};
const div = <div style={styles} />;
const html = ReactDOMServer.renderToString(div);
expect(html).toContain('"--someColor:#000000"');
});

it('should set style attribute when styles exist', () => {
const styles = {
backgroundColor: '#000',
Expand Down
3 changes: 2 additions & 1 deletion packages/react-dom/src/server/ReactPartialRenderer.js
View file
Open in desktop
Expand Up @@ -209,10 +209,11 @@ function validateDangerousTag(tag) {

const styleNameCache = {};
const processStyleName = function(styleName) {
const isCustomProperty = styleName.indexOf('--') === 0;
bedakb marked this conversation as resolved.
Show resolved Hide resolved
if (styleNameCache.hasOwnProperty(styleName)) {
return styleNameCache[styleName];
}
const result = hyphenateStyleName(styleName);
const result = isCustomProperty ? styleName : hyphenateStyleName(styleName);
styleNameCache[styleName] = result;
return result;
};
Expand Down