feat: Add useHydrateableEffect #17350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Nov 12, 2019
| @@ -1337,6 +1337,7 @@ function getReactiveHookCallbackIndex(calleeNode, options) { | |||
| switch (node.name) { | |||
| case 'useEffect': | |||
| case 'useLayoutEffect': | |||
| case 'useHydrateableEffect': | |||
There was a problem hiding this comment.
Not so sure about the naming. We don't really hydrate an effect since it those are never executed on the server anyway. I only used hydration in the name to communicate that the behavior of the hook is tied to hydration.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9e45e76:
|
Details of bundled changes.Comparing: cf00812...9e45e76 react-test-renderer
react-native-renderer
react-art
react-dom
react-reconciler
ReactDOM: size: 🔺+0.1%, gzip: -0.1% Size changes (experimental) |
Details of bundled changes.Comparing: cf00812...9e45e76 react-native-renderer
react-reconciler
react-dom
react-art
react-test-renderer
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Size changes (stable) |
eps1lon
force-pushed
the
feat/useEnhancedEffect
branch
2 times, most recently
from
ad10a1f
to
e7f2e4b
Compare
eps1lon
force-pushed
the
feat/useEnhancedEffect
branch
from
e7f2e4b
to
48f3731
Compare
eps1lon
force-pushed
the
feat/useEnhancedEffect
branch
from
48f3731
to
9e45e76
Compare
|
Closing since the original issue was resolved in #14927 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve #14927
Rationale
If the component requires a layout effect no current workaround solves the underlying issue. Explicit fallback views are most likely impossible (that's why we need layout in the first place) or the component itself is a sufficient fallback (e.g. the overall markup is renderable on the server but we need to adjust some minor visuals).
Since components using
useLayoutEffectwill always have an inconsistent UI before hydration we can potentially downgrade these effects to passive effects i.e. it's already inconsistent so we might as well make it inconsistent a little bit longer to make room for higher priority work.Behavior