Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize update queue object on mount #17560

Merged
merged 2 commits into from Dec 11, 2019

Commits on Dec 9, 2019

  1. Refactor Update Queues to Fix Rebasing Bug

    Fixes a bug related to rebasing updates. Once an update has committed,
    it should never un-commit, even if interrupted by a higher priority
    update. The fix includes a refactor of how update queues work.
    
    This commit is a combination of two PRs:
    
    - facebook#17483 by @sebmarkbage refactors the hook update queue
    - facebook#17510 by @acdlite refactors the class and root update queue
    
    Landing one without the other would cause state updates to sometimes be
    inconsistent across components, so I've combined them into a single
    commit in case they need to be reverted.
    
    Co-authored-by: Sebastian Markbåge <sema@fb.com>
    Co-authored-by: Andrew Clark <git@andrewclark.io>
    acdlite and sebmarkbage committed Dec 9, 2019
    Copy the full SHA
    66066ea View commit details
    Browse the repository at this point in the history
  2. Initialize update queue object on mount

    Instead of lazily initializing update queue objects on the first update,
    class and host root queues are created on mount. This simplifies the
    logic for appending new updates and matches what we do for hooks.
    acdlite committed Dec 9, 2019
    Copy the full SHA
    7768843 View commit details
    Browse the repository at this point in the history