Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_build_devtools CI job to run test-build-devtools #17631

Merged
merged 6 commits into from
Dec 17, 2019
Merged

Fix test_build_devtools CI job to run test-build-devtools #17631

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
209ced0
Skip abandoned project folders in Jest config
gaearon Dec 16, 2019
549f1be
Fix test_build_devtools to run test-build-devtools
gaearon Dec 16, 2019
3233d78
Exclude console.error plugin for DevTools packages
gaearon Dec 16, 2019
2049b94
Use correct release channel for DevTools tests
gaearon Dec 16, 2019
386796d
Fix TZ dependent test
gaearon Dec 16, 2019
9cea553
Change DT job dependencies
gaearon Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/react-devtools-shared/src/__tests__/inspectedElementContext-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@ describe('InspectedElementContext', () => {
const arrayOfArrays = [[['abc', 123, true], []]];
const div = document.createElement('div');
const exampleFunction = () => {};
const exampleDateISO = '2019-12-31T23:42:42.000Z';
const setShallow = new Set(['abc', 123]);
const mapShallow = new Map([['name', 'Brian'], ['food', 'sushi']]);
const setOfSets = new Set([new Set(['a', 'b', 'c']), new Set([1, 2, 3])]);
Expand Down Expand Up @@ -542,7 +543,7 @@ describe('InspectedElementContext', () => {
// eslint-disable-next-line no-undef
big_int={BigInt(123)}
data_view={dataView}
date={new Date(123)}
date={new Date(exampleDateISO)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂

fn={exampleFunction}
html_element={div}
immutable={immutableMap}
Expand Down Expand Up @@ -634,11 +635,11 @@ describe('InspectedElementContext', () => {

expect(date[meta.inspectable]).toBe(false);
expect(date[meta.type]).toBe('date');
expect(date[meta.preview_long]).toBe(
'Wed Dec 31 1969 16:00:00 GMT-0800 (Pacific Standard Time)',
expect(new Date(date[meta.preview_long]).toISOString()).toBe(
exampleDateISO,
);
expect(date[meta.preview_short]).toBe(
'Wed Dec 31 1969 16:00:00 GMT-0800 (Pacific Standard Time)',
expect(new Date(date[meta.preview_short]).toISOString()).toBe(
exampleDateISO,
);

expect(fn[meta.inspectable]).toBe(false);
Expand Down