Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DevTools CI job to experimental workflow #17640

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 17, 2019

Before #17631, each commit would run 22 jobs on master:

Screen Shot 2019-12-17 at 6 13 05 PM

After it, only 10 jobs run on master:

Screen Shot 2019-12-17 at 6 13 00 PM

I can't figure out why, but putting DevTools build in the "stable" workflow is the only suspicious thing I can see in that PR. So let's try to change that and see if it helps.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 943e158:

Sandbox Source
vigorous-cori-284ip Configuration

@sizebot
Copy link

sizebot commented Dec 17, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 943e158

@gaearon gaearon merged commit 9bb3fbe into facebook:master Dec 17, 2019
@gaearon
Copy link
Collaborator Author

gaearon commented Dec 17, 2019

This looks like it fixes the issue.

@sizebot
Copy link

sizebot commented Dec 17, 2019

Warnings
⚠️ Could not find build artifacts for base commit: 3c54df0

Size changes (stable)

Generated by 🚫 dangerJS against 943e158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants