Add unstable_renderSubtreeIntoContainer and unstable_createPortal feature flags #17880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
threepointone,
bvaughn,
sebmarkbage,
necolas,
gaearon,
lunaruan and
acdlite
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 46cee59:
|
Details of bundled changes.Comparing: 0c04aca...46cee59 react-dom
Size changes (experimental) |
Details of bundled changes.Comparing: 0c04aca...46cee59 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
bvaughn
approved these changes
Jan 21, 2020
trueadm
force-pushed
the
react-dom-unstable-flags
branch
from
d0de0a5
to
da119d5
Compare
necolas
approved these changes
Jan 21, 2020
trueadm
force-pushed
the
react-dom-unstable-flags
branch
2 times, most recently
from
0a96835
to
0447b41
Compare
…ture flags Add flags to other files address feedback Fix The ReactDOM.unstable_createPortal() Trigger build Make message same as before
trueadm
force-pushed
the
react-dom-unstable-flags
branch
from
0447b41
to
e327e4a
Compare
Merged
This was referenced Mar 6, 2020
This was referenced Apr 28, 2020
This was referenced May 4, 2020
|
Just a question: does this mean that portals will be deprecated in the future? |
|
No, in fact the opposite. It means the unstable_ prefixed version for createPortal is removed. Use just createPortal instead. |
This was referenced May 7, 2020
Closed
This was referenced Mar 8, 2021
This was referenced Mar 17, 2021
Bump react-test-renderer from 16.11.0 to 16.13.0
newerton/gostack-template-conceitos-react-native#21
Merged
kassens
added a commit
to kassens/react
that referenced
this pull request
Sep 29, 2022
This was added back in facebook#17880 to make CI pass for an unrelated change. Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since.
kassens
added a commit
to kassens/react
that referenced
this pull request
Sep 29, 2022
This was added back in facebook#17880 to make CI pass for an unrelated change. Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since.
kassens
added a commit
to kassens/react
that referenced
this pull request
Sep 29, 2022
This was added back in facebook#17880 to make CI pass for an unrelated change. Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since.
kassens
added a commit
that referenced
this pull request
Sep 29, 2022
This was added back in #17880 to make CI pass for an unrelated change. This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.
rickhanlonii
pushed a commit
that referenced
this pull request
Oct 5, 2022
This was added back in #17880 to make CI pass for an unrelated change. This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two feature flags:
disableUnstableRenderSubtreeIntoContainerforReactDOM.unstable_renderSubtreeIntoContainerdisableUnstableCreatePortalforReactDOM.unstable_createPortalThese disable the relevant unstable/deprecated ReactDOM APIs. Additionally
ReactDOM.unstable_renderSubtreeIntoContainerhas a deprecation warning message as follows:The ReactDOM.unstable_renderSubtreeIntoContainer() is deprecated and will be removed in a future major release. Consider using React Portals instead.I also changed the flowconfig to have the follow config, otherwise CI fails on this PR:
server.max_workers=4