Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset stateNode in resetWorkInProgress #18448

Merged
merged 2 commits into from Apr 1, 2020

Conversation

sebmarkbage
Copy link
Collaborator

Alternative fix to #18432

resetWorkInProgress is supposed to put the Fiber into the same state as if it was just created by child fiber reconciliation. For newly created fibers, that means that stateNode is null.

eps1lon and others added 2 commits March 31, 2020 13:39
This is supposed to put the Fiber into the same state as if it was just
created by child fiber reconciliation. For newly created fibers, that means
that stateNode is null.
@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Mar 31, 2020
@sizebot
Copy link

sizebot commented Mar 31, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 4089176

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4089176:

Sandbox Source
nervous-johnson-r1mkq Configuration

@sizebot
Copy link

sizebot commented Mar 31, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 4089176

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this closes #18429

@gaearon
Copy link
Collaborator

gaearon commented Mar 31, 2020

Why does resuming code path still exist?

@sebmarkbage
Copy link
Collaborator Author

Not sure. Maybe legacy mode suspense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants